From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: ixp2000: fix type of ixp2000_timer_interrupt
Date: Fri, 12 Feb 2010 11:49:47 +0100 [thread overview]
Message-ID: <20100212104947.GB6590@pengutronix.de> (raw)
In-Reply-To: <1264280500-22878-1-git-send-email-u.kleine-koenig@pengutronix.de>
Hi Russell,
On Sat, Jan 23, 2010 at 10:01:39PM +0100, Uwe Kleine-K?nig wrote:
> This fixes a build warning for 2.6.33-rc5:
>
> arch/arm/mach-ixp2000/core.c:217: warning: initialization from incompatible pointer type
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> arch/arm/mach-ixp2000/core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-ixp2000/core.c b/arch/arm/mach-ixp2000/core.c
> index babb225..e24e3d0 100644
> --- a/arch/arm/mach-ixp2000/core.c
> +++ b/arch/arm/mach-ixp2000/core.c
> @@ -197,7 +197,7 @@ unsigned long ixp2000_gettimeoffset (void)
> return offset / ticks_per_usec;
> }
>
> -static int ixp2000_timer_interrupt(int irq, void *dev_id)
> +static irqreturn_t ixp2000_timer_interrupt(int irq, void *dev_id)
> {
> /* clear timer 1 */
> ixp2000_reg_wrb(IXP2000_T1_CLR, 1);
what do you think about this patch? It's (IMHO) trivial and fixes a
long standing build warning.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2010-02-12 10:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 21:01 [PATCH 1/2] ARM: ixp2000: fix type of ixp2000_timer_interrupt Uwe Kleine-König
2010-02-12 10:49 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100212104947.GB6590@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).