From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: i2c-imx: Autoprobe of eeproms
Date: Sat, 13 Feb 2010 11:50:29 +0100 [thread overview]
Message-ID: <20100213105029.GA14254@pengutronix.de> (raw)
In-Reply-To: <4B75D317.7040801@vmlinux.org>
On Fri, Feb 12, 2010 at 11:15:51PM +0100, Mattias Walstrom wrote:
> I have tried to get autoprobe of eeproms to work on a custom freescale
> mx27-board, and i found out that the i2c-imx driver was missing the
> following, is there a reason for this, most other i2c-bus drivers seems
> to have it?
>
> --- linux-2.6.32.8.orig/drivers/i2c/busses/i2c-imx.c 2010-02-09
> 13:57:19.000000000 +0100
> +++ linux-2.6.32.8/drivers/i2c/busses/i2c-imx.c 2010-02-12
> 11:30:12.000000000 +0100
> @@ -521,6 +521,7 @@
> i2c_imx->adapter.algo = &i2c_imx_algo;
> i2c_imx->adapter.dev.parent = &pdev->dev;
> i2c_imx->adapter.nr = pdev->id;
> + i2c_imx->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
> i2c_imx->irq = irq;
> i2c_imx->base = base;
> i2c_imx->res = res;
Your patch is broken. drivers/i2c/busses/i2c-imx.c uses tabs for
indention, not spaces.
(Note, this doesn't mean I'd ack your patch, see Wolfram's reply.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-02-13 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 22:15 i2c-imx: Autoprobe of eeproms Mattias Walstrom
2010-02-13 7:28 ` Wolfram Sang
2010-02-13 10:50 ` Uwe Kleine-König [this message]
2010-02-14 21:18 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100213105029.GA14254@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).