From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/10] ARM: ftrace: fix and update dynamic ftrace
Date: Sun, 14 Feb 2010 21:23:27 +0530 [thread overview]
Message-ID: <20100214155326.GA2842@debian> (raw)
In-Reply-To: <20100214110840.GA21357@pengutronix.de>
On Sun, Feb 14, 2010 at 12:08:40PM +0100, Uwe Kleine-K?nig wrote:
> > diff --git a/arch/arm/include/asm/ftrace.h b/arch/arm/include/asm/ftrace.h
> > index 103f7ee..4a56a2e 100644
> > --- a/arch/arm/include/asm/ftrace.h
> > +++ b/arch/arm/include/asm/ftrace.h
> > @@ -2,12 +2,29 @@
> > #define _ASM_ARM_FTRACE
> >
> > #ifdef CONFIG_FUNCTION_TRACER
> > -#define MCOUNT_ADDR ((long)(mcount))
> > +#define MCOUNT_ADDR ((unsigned long)(__gnu_mcount_nc))
> hhmm, does this work with both the old and the new mcount function?
Yes, MCOUNT_ADDR is not used by the generic ftrace code directly, but is
instead only passed to our arch specific functions. We determine the
right mcount address to use there:
> +#define OLD_MCOUNT_ADDR ((unsigned long) mcount)
[..]
> +static unsigned long adjust_address(struct dyn_ftrace *rec, unsigned long addr)
> +{
> + if (!rec->arch.old_mcount)
> + return addr;
> +
> + if (addr == MCOUNT_ADDR)
> + addr = OLD_MCOUNT_ADDR;
> + else if (addr == FTRACE_ADDR)
> + addr = OLD_FTRACE_ADDR;
> +
> + return addr;
> +}
I changed MCOUNT_ADDR from mcount to __gnu_mcount_nc because we always
build __gnu_mcount_nc in, but don't build mcount when using Thumb-2.
Rabin
next prev parent reply other threads:[~2010-02-14 15:53 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 19:48 [PATCH 00/10] ARM: ftrace: cleanups, Thumb-2, and dynamic ftrace Rabin Vincent
2010-02-13 19:48 ` [PATCH 01/10] ARM: ftrace: clean up mcount assembly indentation Rabin Vincent
2010-02-13 20:18 ` Uwe Kleine-König
2010-02-22 18:36 ` Frederic Weisbecker
2010-02-13 19:48 ` [PATCH 02/10] ARM: ftrace: document mcount formats Rabin Vincent
2010-02-13 20:37 ` Uwe Kleine-König
2010-02-22 18:06 ` Rabin Vincent
2010-02-22 19:20 ` Uwe Kleine-König
2010-02-23 19:42 ` Rabin Vincent
2010-02-23 20:27 ` Uwe Kleine-König
2010-02-22 18:41 ` Frederic Weisbecker
2010-02-13 19:48 ` [PATCH 03/10] ftrace: allow building without frame pointers Rabin Vincent
2010-02-22 18:36 ` Frederic Weisbecker
2010-02-23 13:44 ` Steven Rostedt
2010-02-13 19:48 ` [PATCH 04/10] ARM: " Rabin Vincent
2010-02-22 19:05 ` Frederic Weisbecker
2010-02-23 13:18 ` Steven Rostedt
2010-02-23 17:11 ` Frederic Weisbecker
2010-02-23 17:58 ` Rabin Vincent
2010-02-23 18:03 ` Steven Rostedt
2010-02-23 18:41 ` Rabin Vincent
2010-02-23 13:47 ` Steven Rostedt
2010-02-13 19:48 ` [PATCH 05/10] ARM: ftrace: add ENDPROC annotations Rabin Vincent
2010-02-13 22:54 ` Catalin Marinas
2010-02-13 19:48 ` [PATCH 06/10] ARM: ftrace: add Thumb-2 support Rabin Vincent
2010-02-13 23:27 ` Catalin Marinas
2010-02-14 16:38 ` Rabin Vincent
2010-02-13 19:48 ` [PATCH 07/10] ftrace: pass KBUILD_CFLAGS to record_mcount.pl Rabin Vincent
2010-02-23 13:30 ` Steven Rostedt
2010-02-23 18:23 ` Rabin Vincent
2010-02-23 18:37 ` Steven Rostedt
2010-02-13 19:48 ` [PATCH 08/10] ARM: ftrace: fix and update dynamic ftrace Rabin Vincent
2010-02-14 11:08 ` Uwe Kleine-König
2010-02-14 15:53 ` Rabin Vincent [this message]
2010-02-13 19:48 ` [PATCH 09/10] ARM: ftrace: add Thumb-2 support to " Rabin Vincent
2010-02-23 13:35 ` Steven Rostedt
2010-02-23 17:10 ` Rabin Vincent
2010-02-13 19:48 ` [PATCH 10/10] ARM: ftrace: enable " Rabin Vincent
2010-02-22 18:16 ` [PATCH 00/10] ARM: ftrace: cleanups, Thumb-2, and " Rabin Vincent
-- strict thread matches above, loose matches on Subject: below --
2010-03-13 6:49 [PATCH 00/10] ARM: ftrace: cleanups, Thumb-2, and dynamic ftrace (v2) Rabin Vincent
2010-03-13 6:49 ` [PATCH 08/10] ARM: ftrace: fix and update dynamic ftrace Rabin Vincent
2010-03-13 17:42 ` Steven Rostedt
2010-03-14 16:56 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100214155326.GA2842@debian \
--to=rabin@rab.in \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).