From: davem@davemloft.net (David Miller)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH][KS8695] Mark network interface as running on ifconfig up
Date: Tue, 16 Feb 2010 16:06:47 -0800 (PST) [thread overview]
Message-ID: <20100216.160647.208330407.davem@davemloft.net> (raw)
In-Reply-To: <4B73E62B.3030305@visionsystems.de>
From: Yegor Yefremov <yegor_sub1@visionsystems.de>
Date: Thu, 11 Feb 2010 12:12:43 +0100
> [KS8695] Mark network interface as running on ifconfig up
>
> Without netif_carrier_on() network interface will not transmit any packets
> after ifconfig down and subsequent ifconfig up.
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>
> Index: linux-2.6.33-rc7/drivers/net/arm/ks8695net.c
> ===================================================================
> --- linux-2.6.33-rc7.orig/drivers/net/arm/ks8695net.c
> +++ linux-2.6.33-rc7/drivers/net/arm/ks8695net.c
> @@ -1371,6 +1371,7 @@ ks8695_open(struct net_device *ndev)
>
> napi_enable(&ksp->napi);
> netif_start_queue(ndev);
> + netif_carrier_on(ndev);
>
> return 0;
> }
>
Only ks8695_link_irq() should be setting the carrier state.
If necessary, reset the PHY on device open so that the link up
interrupt arrives and the code handling that event can set the carrier
status properly.
This is how every other driver handles this situation.
next prev parent reply other threads:[~2010-02-17 0:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 11:12 [PATCH][KS8695] Mark network interface as running on ifconfig up Yegor Yefremov
2010-02-17 0:06 ` David Miller [this message]
2010-02-22 15:47 ` Yegor Yefremov
2010-02-26 9:20 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2010-02-11 9:05 Yegor Yefremov
2010-02-11 10:56 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100216.160647.208330407.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).