linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/11] arm: omap: musb: ioremap only what's ours
Date: Fri, 19 Feb 2010 15:44:14 -0800	[thread overview]
Message-ID: <20100219234414.GH21755@atomide.com> (raw)
In-Reply-To: <A24693684029E5489D1D202277BE89445369164A@dlee02.ent.ti.com>

* Aguirre, Sergio <saaguirre@ti.com> [100219 15:34]:
> Hi,
> 
> > -----Original Message-----
> > From: linux-omap-owner at vger.kernel.org [mailto:linux-omap-
> > owner at vger.kernel.org] On Behalf Of Tony Lindgren
> > Sent: Friday, February 19, 2010 5:30 PM
> > To: linux-arm-kernel at lists.infradead.org
> > Cc: Felipe Balbi; linux-omap at vger.kernel.org; linux-usb at vger.kernel.org
> > Subject: [PATCH 03/11] arm: omap: musb: ioremap only what's ours
> > 
> > From: Felipe Balbi <felipe.balbi@nokia.com>
> > 
> > omap3430 TRM says the OTG address space is 4k, not 8k.
> > 
> > Cc: linux-usb at vger.kernel.org
> > Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > ---
> >  arch/arm/mach-omap2/usb-musb.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-
> > musb.c
> > index a80441d..ba71f76 100644
> > --- a/arch/arm/mach-omap2/usb-musb.c
> > +++ b/arch/arm/mach-omap2/usb-musb.c
> > @@ -152,7 +152,7 @@ void __init usb_musb_init(void)
> >  		musb_resources[0].start = OMAP243X_HS_BASE;
> >  	else
> >  		musb_resources[0].start = OMAP34XX_HSUSB_OTG_BASE;
> > -	musb_resources[0].end = musb_resources[0].start + SZ_8K - 1;
> > +	musb_resources[0].end = musb_resources[0].start + SZ_4K - 1;
> 
> I'm just curious...
> 
> Is this valid also if cpu_is_243x() ?

Yes, the other 4K is for the L4 interconnect.

Tony

  reply	other threads:[~2010-02-19 23:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-19 23:29 [PATCH 00/11] omap updates for 2.6.34, part 4 Tony Lindgren
2010-02-19 23:30 ` [PATCH 01/11] USB: Add empty functions in otg.h Tony Lindgren
2010-02-19 23:30 ` [PATCH 02/11] omap: musb: Remove #ifdef from board-omap3evm.c Tony Lindgren
2010-02-19 23:30 ` [PATCH 03/11] arm: omap: musb: ioremap only what's ours Tony Lindgren
2010-02-19 23:37   ` Aguirre, Sergio
2010-02-19 23:44     ` Tony Lindgren [this message]
2010-02-19 23:55       ` Aguirre, Sergio
2010-02-20  0:10         ` Tony Lindgren
2010-02-19 23:30 ` [PATCH 04/11] omap: musb: Pass board specific data from board file Tony Lindgren
2010-02-19 23:30 ` [PATCH 05/11] omap: musb: remove unused data Tony Lindgren
2010-02-19 23:30 ` [PATCH 06/11] arm: omap: musb: we can use clk framework Tony Lindgren
2010-02-19 23:30 ` [PATCH 07/11] omap: musb: remove unused soft_con field Tony Lindgren
2010-02-19 23:30 ` [PATCH 08/11] omap: musb: remove unused dma data Tony Lindgren
2010-02-19 23:30 ` [PATCH 09/11] omap: musb: remove unnecessary return Tony Lindgren
2010-02-19 23:30 ` [PATCH 10/11] omap: musb: get rid of dyn_fifo Tony Lindgren
2010-02-23 14:55   ` Thomas Weber
2010-02-23 15:09     ` Andreas Hartmetz
2010-02-23 15:20       ` Gadiyar, Anand
2010-02-23 18:58         ` Tony Lindgren
2010-02-19 23:30 ` [PATCH 11/11] omap: musb: Add USB support to 4430 SDP board file Tony Lindgren
2010-02-20  8:30 ` [PATCH 00/11] omap updates for 2.6.34, part 4 Shilimkar, Santosh
2010-02-22 21:37   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100219234414.GH21755@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).