From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] s3c24xx_ts: report touch only when stylus is down
Date: Sun, 21 Feb 2010 14:51:25 -0800 [thread overview]
Message-ID: <20100221225125.GA18604@core.coreip.homeip.net> (raw)
In-Reply-To: <201002212344.39633.anarsoul@gmail.com>
On Sun, Feb 21, 2010 at 11:44:34PM +0200, Vasily Khoruzhick wrote:
> ? ????????? ?? 21 ??????? 2010 16:27:13 ????? Nelson Castillo ???????:
> > I remember I got bit by this also when I scheduled more conversions
> > without a timer; pen-up event would not get noticed. I didn't check
> > the specs to see if there was a way to configure the HW to do
> > otherwise.
>
> UPDOWN bits in ADCDAT0 and ADCDAT1 are valid only in WAIT4INT mode, it's wrong
> to check them in select callback because ADC is not in WAIT4INT mode.
We do put it in WAIT4INT mode rigtht there though so it looks like we
just need to move that call (well the original doing WAIT4INT | INT_UP)
before we check for pen state.
--
Dmitry
next prev parent reply other threads:[~2010-02-21 22:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 16:32 [PATCH 0/4] s3c24xx_ts driver fixes Vasily Khoruzhick
2010-02-18 16:32 ` [PATCH 1/4] Add resources description for s3c24xx ts driver Vasily Khoruzhick
2010-02-21 23:12 ` Ben Dooks
2010-02-18 16:32 ` [PATCH 2/4] s3c24xx_ts: report touch only when stylus is down Vasily Khoruzhick
2010-02-19 9:17 ` Dmitry Torokhov
2010-02-19 10:02 ` Vasily Khoruzhick
2010-02-21 7:35 ` Dmitry Torokhov
2010-02-21 9:05 ` Vasily Khoruzhick
2010-02-21 9:41 ` Dmitry Torokhov
2010-02-21 10:10 ` Vasily Khoruzhick
2010-02-21 10:28 ` Dmitry Torokhov
2010-02-21 10:33 ` Vasily Khoruzhick
2010-02-21 14:27 ` Nelson Castillo
2010-02-21 21:44 ` Vasily Khoruzhick
2010-02-21 22:51 ` Dmitry Torokhov [this message]
2010-02-21 22:58 ` Vasily Khoruzhick
2010-02-22 7:14 ` Dmitry Torokhov
2010-02-22 8:58 ` Vasily Khoruzhick
2010-02-22 9:03 ` Vasily Khoruzhick
2010-02-18 16:32 ` [PATCH 3/4] s3c24xx_adc: disable/enable IRQ on suspend/resume Vasily Khoruzhick
2010-02-21 23:12 ` Ben Dooks
2010-02-18 16:32 ` [PATCH 4/4] s3c24xx_ts: re-enable IRQ on resume Vasily Khoruzhick
2010-02-19 9:05 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100221225125.GA18604@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).