From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MXC: mach_armadillo5x0: Add USB Host support.
Date: Thu, 25 Feb 2010 10:35:55 +0100 [thread overview]
Message-ID: <20100225093555.GA10399@pengutronix.de> (raw)
In-Reply-To: <1267090289.2722.4.camel@realization>
Hi Alberto,
> > I think you need to protect all hunks by
> > #ifdef CONFIG_USB_ULPI
> >
> > For the pin-setup it's not important, but you must not call
> > otg_ulpi_create if USB_ULPI isn't configured.
> >
> > Best regards
> > Uwe
> >
>
> Ok, I'd seen this protection in pcm037 but I thought that on
> my board USB will be always enabled.
This breaks make randconfig, so either (a) add the #ifdefs or (b) select
USB_ULPI. IMHO (a) is preferable.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2010-02-25 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 23:27 [PATCH] MXC: mach_armadillo5x0: Add USB Host support Alberto Panizzo
2010-02-25 8:02 ` Uwe Kleine-König
2010-02-25 9:31 ` Alberto Panizzo
2010-02-25 9:35 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100225093555.GA10399@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).