From mboxrd@z Thu Jan 1 00:00:00 1970 From: error27@gmail.com (Dan Carpenter) Date: Fri, 26 Feb 2010 23:20:46 +0300 Subject: [PATCH 1/7] mmc: at91_mci: fix pointer errors In-Reply-To: <9535dc8dfe4476a0314b9513fb9d37862faa731d.1267209149.git.nicolas.ferre@atmel.com> References: <9535dc8dfe4476a0314b9513fb9d37862faa731d.1267209149.git.nicolas.ferre@atmel.com> Message-ID: <20100226201934.GG8417@bicker> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Feb 26, 2010 at 07:39:29PM +0100, Nicolas Ferre wrote: > From: Wolfgang Muees > > Fixes two pointer errors, one which leads to memory overwrites if used with > large chunks of data. > > Signed-off-by: Wolfgang Muees > Signed-off-by: Nicolas Ferre > --- > drivers/mmc/host/at91_mci.c | 8 +++++--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/at91_mci.c b/drivers/mmc/host/at91_mci.c > index 63924e0..6835104 100644 > --- a/drivers/mmc/host/at91_mci.c > +++ b/drivers/mmc/host/at91_mci.c > @@ -227,11 +227,13 @@ static inline void at91_mci_sg_to_dma(struct at91mci_host *host, struct mmc_data > for (index = 0; index < (amount / 4); index++) > *dmabuf++ = swab32(sgbuffer[index]); > } else { > - memcpy(dmabuf, sgbuffer, amount); > - dmabuf += amount; > + char *tmpv = (char *)dmabuf; > + memcpy(tmpv, sgbuffer, amount); > + tmpv += amount; > + dmabuf = (unsigned *)tmpv; > } > > - kunmap_atomic(sgbuffer, KM_BIO_SRC_IRQ); > + kunmap_atomic(((void *)sgbuffer)-sg->offset, KM_BIO_SRC_IRQ); Please put spaces around the minus sign. kunmap_atomic(((void *)sgbuffer) - sg->offset, KM_BIO_SRC_IRQ); regards, dan carpenter > > if (size == 0) > break; > -- > 1.5.6.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/