From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] i2c/pxa: only define 'blue_murder'-function if DEBUG is #defined
Date: Sun, 28 Feb 2010 15:55:02 +0000 [thread overview]
Message-ID: <20100228155502.GB16745@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1267009306-17227-2-git-send-email-u.kleine-koenig@pengutronix.de>
On Wed, Feb 24, 2010 at 12:01:45PM +0100, Uwe Kleine-K?nig wrote:
> From: Wolfram Sang <w.sang@pengutronix.de>
>
> This talkative function is also called on timeouts. As timeouts can
> happen on regular writes to EEPROMs (no error case), this creates false
> positives. Giving lots of details is interesting only for developers
> anyhow, so just use the function if DEBUG is #defined.
Are you sure this is safe? If you time out the write before it completes,
how do you know if the write was successful?
I don't think this is "no error code" nor "false positive". If the timeout
is too short for your EEPROMs, then the timeout needs to be increased.
next prev parent reply other threads:[~2010-02-28 15:55 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 19:03 [PATCH 1/2] [ARM] i2c/pxa: remove unused macro Uwe Kleine-König
2009-11-03 19:03 ` [PATCH 2/2] [ARM] i2c/pxa: only define 'blue_murder'-function if DEBUG is #defined Uwe Kleine-König
2009-11-03 19:06 ` [PATCH 1/2] [ARM] i2c/pxa: remove unused macro Pavel Machek
2009-11-03 20:00 ` Uwe Kleine-König
2009-11-03 21:01 ` Russell King
2009-11-03 22:12 ` Ben Dooks
2009-11-04 19:06 ` Russell King - ARM Linux
2009-11-04 9:00 ` Uwe Kleine-König
2009-11-03 22:13 ` Ben Dooks
2009-11-09 8:18 ` [PATCH 1/2 RESENT] " Uwe Kleine-König
2009-11-09 8:18 ` [PATCH 2/2 RESENT] [ARM] i2c/pxa: only define 'blue_murder'-function if DEBUG is #defined Uwe Kleine-König
2009-11-09 8:58 ` Eric Miao
2009-11-19 19:15 ` [PATCH 1/2 RESEND#2] i2c/pxa: remove unused macro Uwe Kleine-König
2009-11-19 19:15 ` [PATCH 2/2 RESEND#2] i2c/pxa: only define 'blue_murder'-function if DEBUG is #defined Uwe Kleine-König
2010-02-24 11:00 ` my i2c-patches for 2.6.34 Uwe Kleine-König
2010-02-24 11:01 ` [PATCH 1/3] i2c/pxa: remove unused macro Uwe Kleine-König
2010-03-22 21:04 ` Uwe Kleine-König
2010-03-22 21:54 ` Roel Kluin
2010-02-24 11:01 ` [PATCH 2/3] i2c/pxa: only define 'blue_murder'-function if DEBUG is #defined Uwe Kleine-König
2010-02-28 15:55 ` Russell King - ARM Linux [this message]
2010-03-22 21:02 ` Uwe Kleine-König
2010-04-18 13:22 ` Wolfram Sang
2010-04-18 13:45 ` Russell King - ARM Linux
2010-04-18 14:05 ` Wolfram Sang
2010-04-18 14:11 ` Pavel Machek
2010-02-24 11:01 ` [PATCH 3/3] MAINTAINERS: add i2c tree for embedded platforms Uwe Kleine-König
2010-02-28 15:57 ` Russell King - ARM Linux
2010-03-01 9:07 ` Uwe Kleine-König
2010-03-01 10:38 ` Jean Delvare
2010-03-01 11:12 ` [PATCH] " Uwe Kleine-König
2010-03-22 21:03 ` Uwe Kleine-König
2009-11-26 10:44 ` [PATCH 1/2 RESEND#2] i2c/pxa: remove unused macro Uwe Kleine-König
2009-12-08 21:18 ` Uwe Kleine-König
2009-12-08 21:44 ` Jean Delvare
2009-12-08 22:07 ` Uwe Kleine-König
2009-12-09 8:11 ` Jean Delvare
2009-12-16 13:46 ` Uwe Kleine-König
2010-01-12 10:58 ` Uwe Kleine-König
2010-01-25 9:28 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100228155502.GB16745@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).