From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] CLKDEV: return from clk_find as soon as we get maching clk
Date: Wed, 3 Mar 2010 19:44:22 +0000 [thread overview]
Message-ID: <20100303194422.GD4302@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20100302210138.GB25807@pengutronix.de>
On Tue, Mar 02, 2010 at 10:01:38PM +0100, Uwe Kleine-K?nig wrote:
> I starred a the code a bit, but I don't see the problem here. match is
> always <= 3 so if it is 3 in one iteration best increases to 3 and clk
> isn't touched anymore. The other statements in the loop have no side
> effects either.
Yes, you're right - I thought there was some additional code at the end
of the function - was thinking of a previous revision of the code.
I'd still prefer the conditional code to be a 'clk = p->clk; break;'
though, to keep the flow of the code the same.
prev parent reply other threads:[~2010-03-03 19:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 11:05 [PATCH] CLKDEV: return from clk_find as soon as we get maching clk Viresh KUMAR
2010-03-02 20:39 ` Russell King - ARM Linux
2010-03-02 21:01 ` Uwe Kleine-König
2010-03-03 19:44 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100303194422.GD4302@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).