* [PATCH] s3c244x: Fix compilation issue due to moved cpufreq-related files
@ 2010-03-03 14:38 Vasily Khoruzhick
2010-03-04 23:20 ` Ben Dooks
0 siblings, 1 reply; 3+ messages in thread
From: Vasily Khoruzhick @ 2010-03-03 14:38 UTC (permalink / raw)
To: linux-arm-kernel
cpufreq-related files were moved but Makefiles were not modified, and it
breaks compilation when CONFIG_S3C2440_CPUFREQ=y.
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
arch/arm/mach-s3c2440/Makefile | 4 ----
arch/arm/plat-s3c24xx/Makefile | 4 ++++
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-s3c2440/Makefile b/arch/arm/mach-s3c2440/Makefile
index c85ba32..1825516 100644
--- a/arch/arm/mach-s3c2440/Makefile
+++ b/arch/arm/mach-s3c2440/Makefile
@@ -19,10 +19,6 @@ obj-$(CONFIG_S3C2440_DMA) += dma.o
obj-$(CONFIG_CPU_S3C244X) += s3c244x.o
obj-$(CONFIG_CPU_S3C244X) += s3c244x-irq.o
obj-$(CONFIG_CPU_S3C244X) += s3c244x-clock.o
-obj-$(CONFIG_S3C2440_CPUFREQ) += s3c2440-cpufreq.o
-
-obj-$(CONFIG_S3C2440_PLL_12000000) += s3c2440-pll-12000000.o
-obj-$(CONFIG_S3C2440_PLL_16934400) += s3c2440-pll-16934400.o
# Machine support
diff --git a/arch/arm/plat-s3c24xx/Makefile b/arch/arm/plat-s3c24xx/Makefile
index c2237c4..b3a7ac2 100644
--- a/arch/arm/plat-s3c24xx/Makefile
+++ b/arch/arm/plat-s3c24xx/Makefile
@@ -22,6 +22,10 @@ obj-$(CONFIG_S3C24XX_DCLK) += clock-dclk.o
obj-$(CONFIG_CPU_FREQ_S3C24XX) += cpu-freq.o
obj-$(CONFIG_CPU_FREQ_S3C24XX_DEBUGFS) += cpu-freq-debugfs.o
+obj-$(CONFIG_S3C2440_CPUFREQ) += s3c2440-cpufreq.o
+
+obj-$(CONFIG_S3C2440_PLL_12000000) += s3c2440-pll-12000000.o
+obj-$(CONFIG_S3C2440_PLL_16934400) += s3c2440-pll-16934400.o
# Architecture dependant builds
--
1.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] s3c244x: Fix compilation issue due to moved cpufreq-related files
2010-03-03 14:38 [PATCH] s3c244x: Fix compilation issue due to moved cpufreq-related files Vasily Khoruzhick
@ 2010-03-04 23:20 ` Ben Dooks
2010-03-05 7:04 ` Vasily Khoruzhick
0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks @ 2010-03-04 23:20 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Mar 03, 2010 at 04:38:15PM +0200, Vasily Khoruzhick wrote:
> cpufreq-related files were moved but Makefiles were not modified, and it
> breaks compilation when CONFIG_S3C2440_CPUFREQ=y.
I've fixed this by moving the files instead of hte makefile. Commit will
be in next-samsung soon. Thanks for pointing this out.
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
> arch/arm/mach-s3c2440/Makefile | 4 ----
> arch/arm/plat-s3c24xx/Makefile | 4 ++++
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-s3c2440/Makefile b/arch/arm/mach-s3c2440/Makefile
> index c85ba32..1825516 100644
> --- a/arch/arm/mach-s3c2440/Makefile
> +++ b/arch/arm/mach-s3c2440/Makefile
> @@ -19,10 +19,6 @@ obj-$(CONFIG_S3C2440_DMA) += dma.o
> obj-$(CONFIG_CPU_S3C244X) += s3c244x.o
> obj-$(CONFIG_CPU_S3C244X) += s3c244x-irq.o
> obj-$(CONFIG_CPU_S3C244X) += s3c244x-clock.o
> -obj-$(CONFIG_S3C2440_CPUFREQ) += s3c2440-cpufreq.o
> -
> -obj-$(CONFIG_S3C2440_PLL_12000000) += s3c2440-pll-12000000.o
> -obj-$(CONFIG_S3C2440_PLL_16934400) += s3c2440-pll-16934400.o
>
> # Machine support
>
> diff --git a/arch/arm/plat-s3c24xx/Makefile b/arch/arm/plat-s3c24xx/Makefile
> index c2237c4..b3a7ac2 100644
> --- a/arch/arm/plat-s3c24xx/Makefile
> +++ b/arch/arm/plat-s3c24xx/Makefile
> @@ -22,6 +22,10 @@ obj-$(CONFIG_S3C24XX_DCLK) += clock-dclk.o
>
> obj-$(CONFIG_CPU_FREQ_S3C24XX) += cpu-freq.o
> obj-$(CONFIG_CPU_FREQ_S3C24XX_DEBUGFS) += cpu-freq-debugfs.o
> +obj-$(CONFIG_S3C2440_CPUFREQ) += s3c2440-cpufreq.o
> +
> +obj-$(CONFIG_S3C2440_PLL_12000000) += s3c2440-pll-12000000.o
> +obj-$(CONFIG_S3C2440_PLL_16934400) += s3c2440-pll-16934400.o
>
> # Architecture dependant builds
>
> --
> 1.7.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] s3c244x: Fix compilation issue due to moved cpufreq-related files
2010-03-04 23:20 ` Ben Dooks
@ 2010-03-05 7:04 ` Vasily Khoruzhick
0 siblings, 0 replies; 3+ messages in thread
From: Vasily Khoruzhick @ 2010-03-05 7:04 UTC (permalink / raw)
To: linux-arm-kernel
? ????????? ?? 5 ????? 2010 01:20:06 ????? Ben Dooks ???????:
> I've fixed this by moving the files instead of hte makefile. Commit will
> be in next-samsung soon. Thanks for pointing this out.
Sorry, but it seems you forgot about s3c2440-cpufreq.c in commit 8997de30ad
(look at my patch again :)). Please move it from plat-s3c244x to arch-s3c2440
too.
Regards,
Vasily
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100305/79aa97f0/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-05 7:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-03 14:38 [PATCH] s3c244x: Fix compilation issue due to moved cpufreq-related files Vasily Khoruzhick
2010-03-04 23:20 ` Ben Dooks
2010-03-05 7:04 ` Vasily Khoruzhick
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).