linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 16/19] OMAP4: fix temporary hacks that break multi-omap PM
Date: Thu, 11 Mar 2010 15:48:44 -0800	[thread overview]
Message-ID: <20100311234844.4500.30209.stgit@baageli.muru.com> (raw)
In-Reply-To: <20100311234404.4500.82861.stgit@baageli.muru.com>

From: Kevin Hilman <khilman@deeprootsystems.com>

When building for multi-omap, and OMAP4 is enabled, CONFIG_ARCH_OMAP4
will be true and prevent included code from building/running for
OMAP2/3 as well.

This problem exists in io.c where some hwmod/PM/SDRC init code is
prevented from running even on OMAP2/3 when OMAP4 is included in a
multi-OMAP build.

A quick glance suggests that this #ifndef is no longer needed in most
of the cases.  In the remaining cases, the function is wrapped with
"if (cpu_is_omap24xx() || cpu_is_omap34xx())" which will be optimized
out for OMAP4-only builds.

Note that this is only a short-term fix.  Longer-term, OMAP4
needs to create init functions for SDRC and hwmod late-init.

Tested-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/mach-omap2/io.c |   13 ++++++-------
 1 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c
index ae89d55..87f676a 100644
--- a/arch/arm/mach-omap2/io.c
+++ b/arch/arm/mach-omap2/io.c
@@ -309,7 +309,6 @@ void __init omap2_init_common_hw(struct omap_sdrc_params *sdrc_cs0,
 {
 	pwrdm_init(powerdomains_omap);
 	clkdm_init(clockdomains_omap, clkdm_autodeps);
-#ifndef CONFIG_ARCH_OMAP4 /* FIXME: Remove this once the clkdev is ready */
 	if (cpu_is_omap242x())
 		omap2420_hwmod_init();
 	else if (cpu_is_omap243x())
@@ -319,7 +318,6 @@ void __init omap2_init_common_hw(struct omap_sdrc_params *sdrc_cs0,
 	omap2_mux_init();
 	/* The OPP tables have to be registered before a clk init */
 	omap_pm_if_early_init(mpu_opps, dsp_opps, l3_opps);
-#endif
 
 	if (cpu_is_omap2420())
 		omap2420_clk_init();
@@ -333,11 +331,12 @@ void __init omap2_init_common_hw(struct omap_sdrc_params *sdrc_cs0,
 		pr_err("Could not init clock framework - unknown CPU\n");
 
 	omap_serial_early_init();
-#ifndef CONFIG_ARCH_OMAP4
-	omap_hwmod_late_init();
+	if (cpu_is_omap24xx() || cpu_is_omap34xx())   /* FIXME: OMAP4 */
+		omap_hwmod_late_init();
 	omap_pm_if_init();
-	omap2_sdrc_init(sdrc_cs0, sdrc_cs1);
-	_omap2_init_reprogram_sdrc();
-#endif
+	if (cpu_is_omap24xx() || cpu_is_omap34xx()) {
+		omap2_sdrc_init(sdrc_cs0, sdrc_cs1);
+		_omap2_init_reprogram_sdrc();
+	}
 	gpmc_init();
 }

  parent reply	other threads:[~2010-03-11 23:48 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-11 23:48 [PATCH 00/19] omap-fixes for 2.6.34-rc1 Tony Lindgren
2010-03-11 23:48 ` [PATCH 01/19] omap3: Fix compile for Touch Book early_param Tony Lindgren
2010-03-11 23:48 ` [PATCH 02/19] omap2/3/4: ehci: avoid compiler error with touchbook Tony Lindgren
2010-03-11 23:48 ` [PATCH 03/19] omap4: Fix build break by moving omap_smc1 into a separate .S Tony Lindgren
2010-03-11 23:48 ` [PATCH 04/19] omap2: add USB initialization for tusb6010 Tony Lindgren
2010-03-11 23:48 ` [PATCH 05/19] omap2: Update n8x0 defconfig to test multi-omap and DMA api changes Tony Lindgren
2010-03-11 23:48 ` [PATCH 06/19] omap: Enable PM_RUNTIME in defconfigs to avoid USB compile errors Tony Lindgren
2010-03-11 23:48 ` [PATCH 07/19] OMAP2: serial.c: Fix number of uarts in early_init Tony Lindgren
2010-03-11 23:48 ` [PATCH 08/19] omap2/3/4: mailbox: remove compiler warning Tony Lindgren
2010-03-11 23:48 ` [PATCH 09/19] omap: pass the reboot command to the boot loader Tony Lindgren
2010-03-11 23:48 ` [PATCH 10/19] omap: Checkpatch cleanup for blizzard.h Tony Lindgren
2010-03-11 23:48 ` [PATCH 11/19] omap3: Fix support for the LEDs connected to GPIO outputs on IGEP v2board Tony Lindgren
2010-03-11 23:48 ` [PATCH 12/19] omap: Fix gpio_resume_after_retention Tony Lindgren
2010-03-11 23:50   ` Aguirre, Sergio
2010-03-11 23:56     ` Tony Lindgren
2010-03-12  0:04       ` Aguirre, Sergio
2010-03-12 10:37         ` Gadiyar, Anand
2010-03-12 13:19           ` Felipe Balbi
2010-03-12 14:00             ` Aguirre, Sergio
2010-03-11 23:48 ` [PATCH 13/19] omap: mach-omap2/io.c: fix function declarations Tony Lindgren
2010-03-11 23:48 ` [PATCH 14/19] omap3: pandora: add missing i2c3 board_info Tony Lindgren
2010-03-11 23:48 ` [PATCH 15/19] OMAP2: cpu_is_omap2*: fix compile-time removal of unused code Tony Lindgren
2010-03-11 23:48 ` Tony Lindgren [this message]
2010-03-11 23:48 ` [PATCH 17/19] omap: Add DSI regulator supply to OMAP3EVM board file Tony Lindgren
2010-03-12  4:48   ` Hiremath, Vaibhav
2010-03-12 17:12     ` Tony Lindgren
2010-03-12 17:18       ` Tony Lindgren
2010-03-11 23:59 ` [PATCH 18/19] " Tony Lindgren
2010-03-12  0:06   ` Tony Lindgren
2010-03-12  0:00 ` [PATCH 19/19] omap: McBSP: Drop unnecessary status/error bit clearing on reg_cacheretrieved register values Tony Lindgren
2010-03-12  0:10   ` Tony Lindgren
2010-03-12  0:11 ` [PATCH 19b/19] ARM/OMAP: Remove the +x bit from a couple of source files Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100311234844.4500.30209.stgit@baageli.muru.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).