public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: me@felipebalbi.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] USB: musb: omap2430: add mode change from A to B
Date: Mon, 15 Mar 2010 18:10:25 +0200	[thread overview]
Message-ID: <20100315161024.GC3879@gandalf> (raw)
In-Reply-To: <4B9E187E.6090802@ru.mvista.com>

On Mon, Mar 15, 2010 at 02:22:38PM +0300, Sergei Shtylyov wrote:
>    The whole musb_platform_set_mode() seems to be implemented 
> incorrectly on OMAPs -- it shouldn't touch the DevCtl.Session bit. This 

correct. It should be changing the id pin rules just like in tusb6010.c

> function should control the ID pin override instead -- if the controller 
> supports it. SRP must be initiated thru other means, i.e. 'srp' file in 
> sysfs.

via musb_gadget_wakeup()

-- 
balbi

  reply	other threads:[~2010-03-15 16:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-15 10:23 [PATCH 1/2] USB: musb: add two states to handle vbus error Wang Hui
2010-03-15 10:23 ` [PATCH 2/2] USB: musb: omap2430: add mode change from A to B Wang Hui
2010-03-15 11:22   ` Sergei Shtylyov
2010-03-15 16:10     ` Felipe Balbi [this message]
2010-03-16 10:13       ` wanghui
2010-03-16 14:46         ` Felipe Balbi
2010-07-22 15:16   ` Kan-Ru Chen
2010-07-22 16:40     ` Felipe Balbi
2010-07-23  4:38       ` Kan-Ru Chen
2010-03-16 10:49 ` [PATCH 1/2] USB: musb: add two states to handle vbus error wanghui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100315161024.GC3879@gandalf \
    --to=me@felipebalbi.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox