[PATCH 1/3] watchdog: Add support for the Freescale MXC watchdog

[w.sang@pengutronix.de (Wolfram Sang)]

Hi Vladimir,

On Sat, Mar 20, 2010 at 09:40:07PM +0300, Vladimir Zapolskiy wrote:

> The driver is extremely simple, so from my biased position only minor
> benefits can be found in my version:
> * introduced spinlock to protect concurrent write to registers
> * SETTIMEOUT option is present and it works well on imx31
> * correct zero byte write()
> * clock enabled only when watchdog node is opened
> * dynamic wdt structure, which potentially simplifies future support of
>   several watchdogs found on imx51 and imx37 IIRC
> * no critical message on close with unset NOWAYOUT on non-imx1 SoCs
> 
> Your pretty good version supports imx1, and I cann't test my version on
> imx1, because I don't have such hardware on hand.
> 
> Obviously better to update your reviewed one, and I hope some comments or even
> updates from my side could be accepted by you :)

Thanks for agreeing on the procedure and pointing out the benefits of your
driver. I will surely have a look at them and don't be surprised if you will
find this or that incorporated ;) I haven't really started yet, so I might be
missing something: What races do you want to protect against with the spinlock?
The ping?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100321/56fe7884/attachment.sig>