linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Voipac PXA270: UDC and UHC support
Date: Mon, 22 Mar 2010 04:28:49 +0100	[thread overview]
Message-ID: <201003220428.49585.marek.vasut@gmail.com> (raw)
In-Reply-To: <f17812d71003211857n4fc2de73q8c937c74fec5a46@mail.gmail.com>

Dne Po 22. b?ezna 2010 02:57:33 Eric Miao napsal(a):
> >> +static void vpac270_udc_command(int cmd)
> >> +{
> >> +     if (cmd == PXA2XX_UDC_CMD_CONNECT)
> >> +             UP2OCR |= UP2OCR_HXOE | UP2OCR_DPPUE | UP2OCR_DPPUBE;
> >> +     else if (cmd == PXA2XX_UDC_CMD_DISCONNECT)
> >> +             UP2OCR &= ~(UP2OCR_HXOE | UP2OCR_DPPUE | UP2OCR_DPPUBE);
> >
> > In the "DISCONNECT" case, you reset UP2OCR_HXOE, meaning the usb port
> > isn't a USB Device anymore (neither a USB host). If that's on purpose,
> > then all good, in the other case, don't reset that one.
> 
> Marek??

I wasn't able to get it running without reseting the HXOE (so it's there based 
on my tests with the hardware). I'll have to investigate it properly when I have 
more time.

So Eric, could you push this in? I'll send a fix if I figure out something's 
wrong here.

Thanks
> 
> > Otherwise, you can add for the UDC part :
> > Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
> >
> > --
> > Robert
> 

  reply	other threads:[~2010-03-22  3:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-10  4:43 [PATCH] Voipac PXA270: UDC and UHC support Marek Vasut
2010-03-10 11:43 ` Marek Vasut
2010-03-12 17:49   ` Robert Jarzmik
2010-03-12 21:42     ` Marek Vasut
2010-03-13 22:00     ` Marek Vasut
2010-03-15 19:21       ` Robert Jarzmik
2010-03-22  1:57         ` Eric Miao
2010-03-22  3:28           ` Marek Vasut [this message]
2010-03-22  4:04             ` Eric Miao
2010-03-22 13:06               ` Marek Vasut
2010-03-22 13:56                 ` Eric Miao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003220428.49585.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).