From mboxrd@z Thu Jan 1 00:00:00 1970 From: marek.vasut@gmail.com (Marek Vasut) Date: Mon, 22 Mar 2010 04:28:49 +0100 Subject: [PATCH] Voipac PXA270: UDC and UHC support In-Reply-To: References: <201003100543.00221.marek.vasut@gmail.com> <87ljdtpf0e.fsf@free.fr> Message-ID: <201003220428.49585.marek.vasut@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dne Po 22. b?ezna 2010 02:57:33 Eric Miao napsal(a): > >> +static void vpac270_udc_command(int cmd) > >> +{ > >> + if (cmd == PXA2XX_UDC_CMD_CONNECT) > >> + UP2OCR |= UP2OCR_HXOE | UP2OCR_DPPUE | UP2OCR_DPPUBE; > >> + else if (cmd == PXA2XX_UDC_CMD_DISCONNECT) > >> + UP2OCR &= ~(UP2OCR_HXOE | UP2OCR_DPPUE | UP2OCR_DPPUBE); > > > > In the "DISCONNECT" case, you reset UP2OCR_HXOE, meaning the usb port > > isn't a USB Device anymore (neither a USB host). If that's on purpose, > > then all good, in the other case, don't reset that one. > > Marek?? I wasn't able to get it running without reseting the HXOE (so it's there based on my tests with the hardware). I'll have to investigate it properly when I have more time. So Eric, could you push this in? I'll send a fix if I figure out something's wrong here. Thanks > > > Otherwise, you can add for the UDC part : > > Reviewed-by: Robert Jarzmik > > > > -- > > Robert >