From: hjk@linutronix.de (Hans J. Koch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/07] Basic IO mappings for mach-tcc8k
Date: Mon, 22 Mar 2010 23:24:58 +0100 [thread overview]
Message-ID: <20100322222458.GA2547@local> (raw)
In-Reply-To: <63386a3d1003221413p29784233rc0952fba5d921e18@mail.gmail.com>
On Mon, Mar 22, 2010 at 10:13:53PM +0100, Linus Walleij wrote:
> 2010/3/22 Hans J. Koch <hjk@linutronix.de>:
>
> > Map the IO ranges of TCC8xxx peripherals.
> > (...)
> > + ? ? ? {
> > + ? ? ? ? ? ? ? .virtual ? ? ? ?= DATA_TCM_BASE_VIRT, ? /* Data TCM */
> > + ? ? ? ? ? ? ? .pfn ? ? ? ? ? ?= __phys_to_pfn(DATA_TCM_BASE),
> > + ? ? ? ? ? ? ? .length ? ? ? ? = DATA_TCM_SIZE,
> > + ? ? ? ? ? ? ? .type ? ? ? ? ? = MT_DEVICE
> > + ? ? ? },
>
> Hey, that no peripheral, that's onchip TCM memory, MT_DEVICE is
> very inappropriate since it will cause readthrough/writethrough.
>
> Please use the generic TCM memory support as described in
> Documentation/arm/tcm.txt for your TCM memory, example of
> a platform using this can be found in arch/arm/mach-u300,
> just grep -r for TCM. Note the flag in arch/arm/Kconfig as well.
Thanks for that hint. Will fix.
Hans
>
> Any problems, ask.
>
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2010-03-22 22:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 19:19 [PATCH 0/7] Add basic support for Telechips TCC8xxx SoCs Hans J. Koch
2010-03-22 19:21 ` [PATCH 01/07] Introduce plat-tcc Hans J. Koch
2010-03-22 19:23 ` [PATCH 02/07] Add clock framework for plat-tcc Hans J. Koch
2010-03-22 19:24 ` [PATCH 03/07] Introduce plat-tcc irq framework Hans J. Koch
2010-03-22 19:26 ` [PATCH 04/07] Add TCC8xxx system timer Hans J. Koch
2010-03-22 19:27 ` [PATCH 05/07] Basic IO mappings for mach-tcc8k Hans J. Koch
2010-03-22 21:13 ` Linus Walleij
2010-03-22 22:24 ` Hans J. Koch [this message]
2010-03-22 22:28 ` Hans J. Koch
2010-03-23 7:29 ` Linus Walleij
2010-03-23 10:15 ` Hans J. Koch
2010-03-26 17:28 ` Linus Walleij
2010-03-26 17:57 ` Hans J. Koch
2010-03-27 9:33 ` Linus Walleij
2010-03-27 15:26 ` Hans J. Koch
2010-03-22 19:29 ` [PATCH 06/07] Add common platform devices for TCC8xxx SoCs Hans J. Koch
2010-03-22 19:31 ` [PATCH 07/07] Add board support for Telechips TCC8000-SDK board Hans J. Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322222458.GA2547@local \
--to=hjk@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).