[PATCH 05/07] Basic IO mappings for mach-tcc8k

Linus Walleij
2010-03-22T21:13:53Z

2010/3/22 Hans J. Koch <hjk@linutronix.de>:

> Map the IO ranges of TCC8xxx peripherals.
> (...)
> + ? ? ? {
> + ? ? ? ? ? ? ? .virtual ? ? ? ?= DATA_TCM_BASE_VIRT, ? /* Data TCM */
> + ? ? ? ? ? ? ? .pfn ? ? ? ? ? ?= __phys_to_pfn(DATA_TCM_BASE),
> + ? ? ? ? ? ? ? .length ? ? ? ? = DATA_TCM_SIZE,
> + ? ? ? ? ? ? ? .type ? ? ? ? ? = MT_DEVICE
> + ? ? ? },

Hey, that no peripheral, that's onchip TCM memory, MT_DEVICE is
very inappropriate since it will cause readthrough/writethrough.

Please use the generic TCM memory support as described in
Documentation/arm/tcm.txt for your TCM memory, example of
a platform using this can be found in arch/arm/mach-u300,
just grep -r for TCM. Note the flag in arch/arm/Kconfig as well.

Any problems, ask.

Yours,
Linus Walleij