AACI broken with commit 29a4f2d3

[linux@arm.linux.org.uk (Russell King - ARM Linux)]

On Thu, Mar 25, 2010 at 12:02:37PM +0000, Catalin Marinas wrote:
> I can confirm that it solves the reset issue on other RealView boards as
> well. Whether it's the correct fix I can't tell.

Something else is going on then.  Whatever, this patch is totally
incorrect and needs to be reverted.  It's not even doing what the
description in the documentation requires.

I quote from page 3-18, which is mentioned in the commit message which
added this code:

  Data transmitted on slot 2 register, AACISL2TX The AACISL2TX register
  is a read/write register. When a write occurs to this register the data
  it contains is sent on the next available frame in slot 2. If a power
  down is required, then data must be written to AACISL1TX location
  address 0x26, which is recorded by the PrimeCell AACI. If the AACISL2TX
  bit 16 is set, then the PrimeCell AACI goes into power down mode.
  Table 3-11 shows the bit assignment of the AACISL2TX register.

And this is definitely NOT what Philby's code is doing.

The original commit is wrong on soo many levels.