From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Fix virtual kernel memory printing for sparsemem
Date: Thu, 25 Mar 2010 15:10:31 +0000 [thread overview]
Message-ID: <20100325151030.GD6590@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20100325145324.12837.85927.stgit@e102109-lin.cambridge.arm.com>
On Thu, Mar 25, 2010 at 02:53:24PM +0000, Catalin Marinas wrote:
> Commit db9ef1a introduced information printing for the virtual kernel
> memory map but page/end calculation using the pfn goes wrong and
> page_count() generates a data abort or alignment fault (possibly because
> it gets to an uninitialised page structure that looks like a compound
> page).
While this looks fine, I'd like to see a lot of Tested-by's against
this before it's merged - we've had similar code in show_mem()
which has proven to be quite problematical to get right for all the
various different combinations we have.
However, we also have the same method in show_mem() which we know
works fine, so I'd also like to see the problem with using it in
mem_init() fully analysed - rather than a "possibly because".
next prev parent reply other threads:[~2010-03-25 15:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 14:53 [PATCH] ARM: Fix virtual kernel memory printing for sparsemem Catalin Marinas
2010-03-25 15:10 ` Russell King - ARM Linux [this message]
2010-03-25 15:24 ` Catalin Marinas
2010-03-25 15:30 ` Russell King - ARM Linux
2010-03-25 15:37 ` Will Deacon
2010-03-25 16:01 ` Catalin Marinas
2010-03-25 17:46 ` Will Deacon
2010-05-04 16:13 ` Marek Vasut
2010-05-04 16:18 ` Russell King - ARM Linux
2010-05-04 16:28 ` Catalin Marinas
2010-05-04 17:00 ` Marek Vasut
2010-05-04 16:02 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100325151030.GD6590@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).