From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] [RFCv2] arm: add half-word __xchg
Date: Sat, 27 Mar 2010 22:52:40 +0000 [thread overview]
Message-ID: <20100327225240.GC13203@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1269535366-25175-1-git-send-email-virtuoso@slind.org>
On Thu, Mar 25, 2010 at 06:42:46PM +0200, Alexander Shishkin wrote:
> +/*
> + * emulate __xchg() using 32-bit __cmpxchg()
> + */
> +static inline unsigned long __xchg_generic(unsigned long x,
> + volatile void *ptr, int size)
> +{
> + unsigned long *ptrbig = (unsigned long *)((unsigned long)ptr & ~3UL);
> + int shift = ((unsigned)ptr - (unsigned)ptrbig) * 8;
I wonder if we should be using __alignof__ here.
unsigned long *ptrbig = (unsigned long *)((unsigned long)ptr &
(__alignof__(unsigned long) - 1));
Rest of the patch looks fine; it'd be nice to get some tested-by's for it
though.
next prev parent reply other threads:[~2010-03-27 22:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 16:22 __xchg for sizes other than 32bit Imre Deak
2010-03-10 17:35 ` Russell King - ARM Linux
2010-03-10 20:02 ` [PATCH] ARM support single byte cmpxchg and cmpxchg_local on ARMv6 Mathieu Desnoyers
2010-03-10 20:30 ` Russell King - ARM Linux
2010-03-10 21:15 ` Mathieu Desnoyers
2010-03-10 23:16 ` __xchg for sizes other than 32bit Jamie Lokier
2010-03-18 9:29 ` [PATCH 1/1] [RFC] arm: add half-word __xchg Alexander Shishkin
2010-03-18 12:32 ` Mathieu Desnoyers
2010-03-18 12:37 ` Alexander Shishkin
2010-03-18 13:33 ` Alexander Shishkin
2010-03-18 13:50 ` Mathieu Desnoyers
2010-03-18 16:33 ` Imre Deak
2010-03-18 17:21 ` Mathieu Desnoyers
2010-03-18 19:00 ` Imre Deak
2010-03-18 19:30 ` Mathieu Desnoyers
2010-03-19 1:49 ` Jamie Lokier
2010-03-19 2:12 ` Mathieu Desnoyers
2010-03-19 3:36 ` Jamie Lokier
2010-03-25 15:52 ` [PATCH 1/1] [RFCv2] " Alexander Shishkin
2010-03-25 16:42 ` Alexander Shishkin
2010-03-27 22:52 ` Russell King - ARM Linux [this message]
2010-03-28 0:14 ` Jamie Lokier
2010-03-28 0:18 ` Russell King - ARM Linux
2010-03-28 1:00 ` Mathieu Desnoyers
2010-03-28 14:39 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100327225240.GC13203@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).