From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mach-sa1100: Put nanoEngine support back in the kernel.
Date: Sat, 27 Mar 2010 22:55:22 +0000 [thread overview]
Message-ID: <20100327225522.GD13203@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1268338199-32222-1-git-send-email-mroberto@cpti.cetuc.puc-rio.br>
On Thu, Mar 11, 2010 at 05:09:59PM -0300, Marcelo Roberto Jimenez wrote:
> --- /dev/null
> +++ b/arch/arm/configs/nanoengine_defconfig
> @@ -0,0 +1,1396 @@
Please don't include defconfigs along with other code.
> +/*
> + * linux/arch/arm/mach-sa1100/nanoengine.c
> + *
> + * Bright Star Engineering's nanoEngine board init code.
> + *
> + * Copyright (C) 2009 Marcelo Roberto Jimenez <mroberto@cpti.cetuc.puc-rio.br>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + */
> +
> +#include <linux/init.h>
> +#include <linux/kernel.h>
> +#include <linux/mtd/mtd.h>
> +#include <linux/mtd/partitions.h>
> +#include <linux/root_dev.h>
> +#include <linux/tty.h>
Do you really need tty.h in here?
> +
> +#include <asm/mach-types.h>
> +#include <asm/setup.h>
> +
> +#include <asm/mach/arch.h>
> +#include <asm/mach/flash.h>
> +#include <asm/mach/map.h>
> +#include <asm/mach/serial_sa1100.h>
> +
> +#include <mach/hardware.h>
> +
> +#include "generic.h"
> +
> +/* Flash bank 0 */
> +static struct mtd_partition nanoengine_partitions[] = {
> + {
> + .name = "nanoEngine boot firmware and parameter table",
Each '{' should indent the next line by a tab.
next prev parent reply other threads:[~2010-03-27 22:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 20:09 [PATCH] ARM: mach-sa1100: Put nanoEngine support back in the kernel Marcelo Roberto Jimenez
2010-03-27 22:55 ` Russell King - ARM Linux [this message]
2010-03-29 19:10 ` Marcelo Jimenez
-- strict thread matches above, loose matches on Subject: below --
2010-03-29 19:29 Marcelo Roberto Jimenez
[not found] <1268156514-1774-1-git-send-email-mroberto@cpti.cetuc.puc-rio.br>
2010-03-09 18:19 ` Kristoffer Ericson
[not found] <1268148843-13135-1-git-send-email-mroberto@cpti.cetuc.puc-rio.br>
2010-03-09 16:52 ` Kristoffer Ericson
2010-03-09 17:37 ` Marcelo Jimenez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100327225522.GD13203@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).