linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: imre.deak@nokia.com (Imre Deak)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] create generic alignment api (v2)
Date: Sun, 28 Mar 2010 18:40:29 +0300	[thread overview]
Message-ID: <20100328154029.GA21061@localhost> (raw)
In-Reply-To: <20100328012247.GA17763@Krystal>

On Sun, Mar 28, 2010 at 03:22:47AM +0200, ext Mathieu Desnoyers wrote:
>  [...]
> +/**
> + * offset_align - Calculate the offset needed to align an object on its natural
> + *                alignment towards higher addresses.
> + * @align_drift:  object offset from an "alignment"-aligned address.
> + * @alignment:    natural object alignment. Must be non-zero, power of 2.
> + *
> + * Returns the offset that must be added to align towards higher
> + * addresses.
> + */
> +static inline size_t offset_align(size_t align_drift, size_t alignment)
> +{
> +	return (alignment - align_drift) & (alignment - 1);
> +}
> +
> +/**
> + * offset_align_floor - Calculate the offset needed to align an object
> + *                      on its natural alignment towards lower addresses.
> + * @align_drift:  object offset from an "alignment"-aligned address.
> + * @alignment:    natural object alignment. Must be non-zero, power of 2.
> + *
> + * Returns the offset that must be substracted to align towards lower addresses.
> + */
> +static inline size_t offset_align_floor(size_t align_drift, size_t alignment)
> +{
> +	return (align_drift - alignment) & (alignment - 1);
> +}
> +
> +#define object_align(object)						       \
> +	((typeof(object))((size_t) object + offset_align((size_t) object,      \
> +			  sizeof(object))))
> +
> +#define object_align_floor(object)					       \
> +	((typeof(object))((size_t) object - offset_align_floor((size_t) object,\
> +			  sizeof(object))))
> +

Here object must be a pointer, but then sizeof(object) will result in
aligning to the arch word size not the object's natural alignment. Is
this what you intended?

--Imre

  reply	other threads:[~2010-03-28 15:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-28  1:22 [RFC PATCH] create generic alignment api (v2) Mathieu Desnoyers
2010-03-28 15:40 ` Imre Deak [this message]
2010-03-28 18:29   ` Mathieu Desnoyers
2010-03-29  0:09   ` [RFC PATCH] create generic alignment api (v5) Mathieu Desnoyers
     [not found]     ` <20100501183544.GC27062@shisha.kicks-ass.net>
2010-05-01 19:10       ` Mathieu Desnoyers
     [not found]         ` <20100501192915.GD27062@shisha.kicks-ass.net>
2010-05-01 19:45           ` Mathieu Desnoyers
2010-05-01 19:23     ` [PATCH 1/2] create generic alignment api (v6) Alexander Shishkin
2010-05-01 19:24       ` [PATCH 2/2] [RFCv3] arm: add half-word __xchg Alexander Shishkin
2010-05-03 17:27         ` Mathieu Desnoyers
     [not found]           ` <20100505080155.GF27062@shisha.kicks-ass.net>
2010-05-08 23:30             ` Mathieu Desnoyers
2010-05-06 18:12       ` [PATCH 1/2] create generic alignment api (v6) Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100328154029.GA21061@localhost \
    --to=imre.deak@nokia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).