From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] atmel_serial: Atmel RS485 support v2
Date: Thu, 8 Apr 2010 10:01:14 +0100 [thread overview]
Message-ID: <20100408090114.GA31407@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4BBD8C9D.3070401@evidence.eu.com>
On Thu, Apr 08, 2010 at 09:58:21AM +0200, Claudio Scordino wrote:
> diff --git a/arch/arm/include/asm/ioctls.h b/arch/arm/include/asm/ioctls.h
> index a91d8a1..82f2177 100644
> --- a/arch/arm/include/asm/ioctls.h
> +++ b/arch/arm/include/asm/ioctls.h
> @@ -70,6 +70,8 @@
> #define TIOCGICOUNT 0x545D /* read serial port inline interrupt counts */
> #define FIOQSIZE 0x545E
>
> +#define TIOCSRS485 0x5461
Why are you only supporting half the interface?
#define TIOCGRS485 0x542E
#define TIOCSRS485 0x542F
is what is in include/asm-generic/ioctls.h - and it would be a good idea
to use the same numbering as the generic file rather than creating yet
more divergence.
next prev parent reply other threads:[~2010-04-08 9:01 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 7:16 [PATCH] atmel_serial: Atmel RS485 support v2 Claudio Scordino
2010-03-29 19:44 ` Ryan Mallon
2010-03-30 9:07 ` Claudio Scordino
2010-03-30 19:37 ` Ryan Mallon
2010-04-08 7:58 ` Claudio Scordino
2010-04-08 9:01 ` Russell King - ARM Linux [this message]
2010-04-08 10:13 ` Alan Cox
2010-04-08 13:16 ` Claudio Scordino
2010-04-08 13:42 ` Alan Cox
2010-05-26 13:18 ` Nicolas Ferre
2010-05-27 8:37 ` Claudio Scordino
2010-05-27 9:57 ` Nicolas Ferre
2010-05-27 10:29 ` Wolfram Sang
2010-05-28 15:05 ` Claudio Scordino
2010-08-11 9:26 ` [PATCH] Documentation about RS485 serial communications Claudio Scordino
2010-08-11 10:02 ` Philippe De Muyter
2010-08-11 15:32 ` Randy Dunlap
2010-08-11 19:58 ` Claudio Scordino
2010-08-14 12:50 ` Claudio Scordino
2010-08-15 22:02 ` Randy Dunlap
2010-08-15 22:19 ` Russell King - ARM Linux
2010-10-19 12:28 ` Claudio Scordino
2010-10-19 14:29 ` Grant Edwards
2010-10-19 15:27 ` Alexander Stein
2010-10-19 17:22 ` Grant Edwards
2010-10-20 7:36 ` Nicolas Ferre
2010-10-20 8:00 ` Alexander Stein
2010-10-20 18:56 ` Alan Cox
2010-10-24 11:29 ` Claudio Scordino
2010-10-28 15:10 ` Chris Down
2010-10-28 15:31 ` Claudio Scordino
2010-10-28 16:30 ` Chris Down
2010-11-10 9:17 ` Nicolas Ferre
2010-11-10 17:28 ` Greg KH
2010-11-11 10:22 ` Claudio Scordino
2010-11-16 14:30 ` Pavel Machek
2010-11-16 15:23 ` Grant Edwards
2010-11-16 15:28 ` Alexander Stein
2010-11-16 16:13 ` Matt Schulte
2010-11-16 17:20 ` Alan Cox
[not found] ` <ibuh1v$uh6$1@dough.gmane.org>
2010-11-16 20:04 ` Alan Cox
2010-11-30 19:19 ` Pavel Machek
[not found] ` <ibubf5$ev$1@dough.gmane.org>
2010-11-16 18:41 ` Matt Schulte
2010-05-28 9:42 ` [PATCH] atmel_serial: Atmel RS485 support v2 Haavard Skinnemoen
2010-05-28 13:54 ` [PATCH] MAINTAINERS: some Atmel drivers change maintainer Nicolas Ferre
2010-05-28 13:31 ` Haavard Skinnemoen
2010-06-11 7:23 ` Nicolas Ferre
-- strict thread matches above, loose matches on Subject: below --
2010-04-12 9:43 [PATCH] atmel_serial: Atmel RS485 support v2 Philippe De Muyter
2010-04-12 15:55 ` Claudio Scordino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100408090114.GA31407@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).