From: daniel@caiaq.de (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: pxa/raumfeld: fix button name
Date: Thu, 22 Apr 2010 12:19:56 +0200 [thread overview]
Message-ID: <20100422101956.GV30801@buzzloop.caiaq.de> (raw)
In-Reply-To: <1271576129-16133-1-git-send-email-daniel@caiaq.de>
On Sun, Apr 18, 2010 at 09:35:29AM +0200, Daniel Mack wrote:
> "on/off button" was recently renamed to remove the slash character.
> Follow that change in the pin polarity detection as well.
>
> While at it, fix another cosmetic coding style flaw as well.
>
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> Cc: Eric Miao <eric.y.miao@gmail.com>
Eric, can you apply this? Would be nice to have it in .34, but not
totally mandatory.
Thanks,
Daniel
> ---
> arch/arm/mach-pxa/raumfeld.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/raumfeld.c b/arch/arm/mach-pxa/raumfeld.c
> index 3bbc2d8..7582a12 100644
> --- a/arch/arm/mach-pxa/raumfeld.c
> +++ b/arch/arm/mach-pxa/raumfeld.c
> @@ -1001,7 +1001,7 @@ static void __init raumfeld_common_init(void)
> int i;
>
> for (i = 0; i < ARRAY_SIZE(gpio_keys_button); i++)
> - if (!strcmp(gpio_keys_button[i].desc, "on/off button"))
> + if (!strcmp(gpio_keys_button[i].desc, "on_off button"))
> gpio_keys_button[i].active_low = 1;
> }
>
> @@ -1027,8 +1027,7 @@ static void __init raumfeld_common_init(void)
> gpio_direction_output(GPIO_W2W_PDN, 0);
>
> /* this can be used to switch off the device */
> - ret = gpio_request(GPIO_SHUTDOWN_SUPPLY,
> - "supply shutdown");
> + ret = gpio_request(GPIO_SHUTDOWN_SUPPLY, "supply shutdown");
> if (ret < 0)
> pr_warning("Unable to request GPIO_SHUTDOWN_SUPPLY\n");
> else
> --
> 1.7.0.3
>
next prev parent reply other threads:[~2010-04-22 10:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-18 7:35 [PATCH] ARM: pxa/raumfeld: fix button name Daniel Mack
2010-04-22 10:19 ` Daniel Mack [this message]
2010-04-26 21:03 ` Daniel Mack
2010-04-27 2:37 ` Eric Miao
2010-04-27 4:15 ` Daniel Mack
-- strict thread matches above, loose matches on Subject: below --
2010-03-18 18:37 Daniel Mack
2010-03-22 4:02 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100422101956.GV30801@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).