linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial/imx: only parse for iomem resources once
Date: Thu, 22 Apr 2010 16:33:43 +0200	[thread overview]
Message-ID: <20100422143343.GB32348@pengutronix.de> (raw)
In-Reply-To: <1271838838.643120.804272014834.1.gpush@pororo>

On Wed, Apr 21, 2010 at 04:33:58PM +0800, Jeremy Kerr wrote:
> Currently, the iomem resources are parsed in serial_imx_probe, then
> again in imx_request_port and imx_release_port.
> 
> This change uses the imx_port data to retrieve the start and size of the
> memory region, rather than re-parsing the resources through
> platform_get_resource.
> 
> Signed-off-by: Jeremy Kerr <jeremy.kerr@canonical.com>
What are the effects for this regarding run time?  How often are
request_port and release_port called?  I wonder if it's worth to save
the value.  Or what else than run time is your concern?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2010-04-22 14:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21  8:33 [PATCH] serial/imx: only parse for iomem resources once Jeremy Kerr
2010-04-22 14:33 ` Uwe Kleine-König [this message]
2010-04-23  3:02   ` Jeremy Kerr
2010-05-05 10:09 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100422143343.GB32348@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).