From: jeremy.kerr@canonical.com (Jeremy Kerr)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial/imx: only parse for iomem resources once
Date: Fri, 23 Apr 2010 11:02:05 +0800 [thread overview]
Message-ID: <201004231102.06849.jeremy.kerr@canonical.com> (raw)
In-Reply-To: <20100422143343.GB32348@pengutronix.de>
Hi Uwe,
> What are the effects for this regarding run time? How often are
> request_port and release_port called? I wonder if it's worth to save
> the value. Or what else than run time is your concern?
I'm not too concerned with the reduction in run time here - I'd like to be
able to parse the UART config from the device tree, rather than using
platform_get_{irq,resource}.
With this patch, all of the existing parsing is done in serial_imx_probe().
This means we can just abstract the parsing once, rather than having to check
what parsing method (platform or devtree) we're using in request_port and
release_port as well.
See serial_imx_probe_pdata and serial_imx_probe_dt in:
http://kernel.ubuntu.com/git?p=jk/dt/linux-2.6.git;a=blob;f=drivers/serial/imx.c;h=a54f6464d35920a81fdcc9fd93de3283260ab839;hb=2610717ecacfba0db34ad5b28ed6379560108912
for my intended (work-in-progress) approach.
Cheers,
Jeremy
next prev parent reply other threads:[~2010-04-23 3:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 8:33 [PATCH] serial/imx: only parse for iomem resources once Jeremy Kerr
2010-04-22 14:33 ` Uwe Kleine-König
2010-04-23 3:02 ` Jeremy Kerr [this message]
2010-05-05 10:09 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004231102.06849.jeremy.kerr@canonical.com \
--to=jeremy.kerr@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).