From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] i.MX35: remove get_3_3_div helper function
Date: Fri, 23 Apr 2010 14:38:27 +0200 [thread overview]
Message-ID: <20100423123827.GC7882@pengutronix.de> (raw)
In-Reply-To: <4BD172A3.8050500@ru.mvista.com>
On Fri, Apr 23, 2010 at 02:12:51PM +0400, Sergei Shtylyov wrote:
>> static unsigned long get_rate_uart(struct clk *clk)
>> {
>> unsigned long pdr3 = __raw_readl(CCM_BASE + CCM_PDR3);
>> unsigned long pdr4 = __raw_readl(CCM_BASE + CCM_PDR4);
>> - unsigned long div = get_3_3_div(pdr4 >> 10);
>> + unsigned long div = ((pdr4 >> 10) & 0x3f) + 1;
>> if (pdr3 & (1 << 14))
>> return get_rate_arm() / div;
>> @@ -218,7 +213,7 @@ static unsigned long get_rate_sdhc(struct clk *clk)
>> break;
>> }
>> - return rate / get_3_3_div(div);
>> + return rate / (div + 1);
>>
>
> You're adding 1 to divisor twice here...
Look again, these hunks are in two different functions.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2010-04-23 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 7:40 i.MX35 Clock patches Sascha Hauer
2010-04-23 7:40 ` [PATCH 1/2] i.MX35: Fix arm/ahb clock calculation Sascha Hauer
2010-04-23 7:40 ` [PATCH 2/2] i.MX35: remove get_3_3_div helper function Sascha Hauer
2010-04-23 10:12 ` Sergei Shtylyov
2010-04-23 12:38 ` Sascha Hauer [this message]
2010-04-23 13:20 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423123827.GC7882@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).