From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/28] omap: Fix n8x0 mmc_mmc_init compile warnings and typos
Date: Fri, 23 Apr 2010 16:11:20 -0700 [thread overview]
Message-ID: <20100423231120.31953.45582.stgit@baageli.muru.com> (raw)
In-Reply-To: <20100423230829.31953.17334.stgit@baageli.muru.com>
Fix warning: 'return' with a value, in function returning void
in n8x0_mmc_init. Also fix a search and replace typo.
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/mach-omap2/board-n8x0.c | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/mach-omap2/board-n8x0.c b/arch/arm/mach-omap2/board-n8x0.c
index da9bcb8..3ccc34e 100644
--- a/arch/arm/mach-omap2/board-n8x0.c
+++ b/arch/arm/mach-omap2/board-n8x0.c
@@ -216,7 +216,7 @@ static void __init n8x0_onenand_init(void) {}
*/
#define N8X0_SLOT_SWITCH_GPIO 96
#define N810_EMMC_VSD_GPIO 23
-#define NN810_EMMC_VIO_GPIO 9
+#define N810_EMMC_VIO_GPIO 9
static int n8x0_mmc_switch_slot(struct device *dev, int slot)
{
@@ -304,10 +304,10 @@ static void n810_set_power_emmc(struct device *dev,
if (power_on) {
gpio_set_value(N810_EMMC_VSD_GPIO, 1);
msleep(1);
- gpio_set_value(NN810_EMMC_VIO_GPIO, 1);
+ gpio_set_value(N810_EMMC_VIO_GPIO, 1);
msleep(1);
} else {
- gpio_set_value(NN810_EMMC_VIO_GPIO, 0);
+ gpio_set_value(N810_EMMC_VIO_GPIO, 0);
msleep(50);
gpio_set_value(N810_EMMC_VSD_GPIO, 0);
msleep(50);
@@ -468,7 +468,7 @@ static void n8x0_mmc_cleanup(struct device *dev)
if (machine_is_nokia_n810()) {
gpio_free(N810_EMMC_VSD_GPIO);
- gpio_free(NN810_EMMC_VIO_GPIO);
+ gpio_free(N810_EMMC_VIO_GPIO);
}
}
@@ -529,7 +529,7 @@ void __init n8x0_mmc_init(void)
err = gpio_request(N8X0_SLOT_SWITCH_GPIO, "MMC slot switch");
if (err)
- return err;
+ return;
gpio_direction_output(N8X0_SLOT_SWITCH_GPIO, 0);
@@ -537,17 +537,17 @@ void __init n8x0_mmc_init(void)
err = gpio_request(N810_EMMC_VSD_GPIO, "MMC slot 2 Vddf");
if (err) {
gpio_free(N8X0_SLOT_SWITCH_GPIO);
- return err;
+ return;
}
gpio_direction_output(N810_EMMC_VSD_GPIO, 0);
- err = gpio_request(NN810_EMMC_VIO_GPIO, "MMC slot 2 Vdd");
+ err = gpio_request(N810_EMMC_VIO_GPIO, "MMC slot 2 Vdd");
if (err) {
gpio_free(N8X0_SLOT_SWITCH_GPIO);
gpio_free(N810_EMMC_VSD_GPIO);
- return err;
+ return;
}
- gpio_direction_output(NN810_EMMC_VIO_GPIO, 0);
+ gpio_direction_output(N810_EMMC_VIO_GPIO, 0);
}
mmc_data[0] = &mmc1_data;
next prev parent reply other threads:[~2010-04-23 23:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 23:10 [PATCH 00/28] omap fixes for v2.6.34-rc5 Tony Lindgren
2010-04-23 23:11 ` [PATCH 01/28] omap: fix clocksource_32k to start from zero Tony Lindgren
2010-04-23 23:11 ` [PATCH 02/28] arm: omap1: remove dead code from timer32k.c Tony Lindgren
2010-04-23 23:11 ` [PATCH 03/28] omap: gpio: fix incorrect matching of IRQ_TYPE_EDGE_BOTH Tony Lindgren
2010-04-23 23:11 ` [PATCH 04/28] omap: DMA: Init CDAC to zero Tony Lindgren
2010-04-23 23:11 ` [PATCH 05/28] omap4: Fix build break when used with gcc-4.4.1 (2009-q3) Tony Lindgren
2010-04-23 23:11 ` [PATCH 06/28] omap2: Fix ARM processor check for 24xx Tony Lindgren
2010-04-23 23:11 ` Tony Lindgren [this message]
2010-04-23 23:11 ` [PATCH 08/28] omap3: Fix EHCI port for IGEP v2 board Tony Lindgren
2010-04-23 23:11 ` [PATCH 09/28] OMAP4-HSMMC: FIX for MMC5 Controller IRQ Base Tony Lindgren
2010-04-23 23:11 ` [PATCH 10/28] OMAP4: Fix for CONTROL register Base Tony Lindgren
2010-04-23 23:11 ` [PATCH 11/28] omap: Devkit8000: Fix wrong usb port on Devkit8000 Tony Lindgren
2010-04-23 23:11 ` [PATCH 12/28] OMAP4: Clocks: Change SPI Instance Names Tony Lindgren
2010-04-23 23:11 ` [PATCH 13/28] omap: fix the compile error if CONFIG_MTD_NAND_OMAP2 is notenabled Tony Lindgren
2010-04-23 23:11 ` [PATCH 14/28] omap: remove one of the define of INT_34XX_BENCH_MPU_EMUL Tony Lindgren
2010-04-23 23:11 ` [PATCH 15/28] AM3517: initialize i2c subsystem after mux subsystem Tony Lindgren
2010-04-23 23:11 ` [PATCH 16/28] omap: fix a gpmc nand problem Tony Lindgren
2010-04-23 23:11 ` [PATCH 17/28] omap: rx51_defconfig: Remove duplicate phonet Tony Lindgren
2010-04-23 23:11 ` [PATCH 18/28] omap: rx51_defconfig: Remove CONFIG_SYSFS_DEPRECATED*=y options Tony Lindgren
2010-04-23 23:11 ` [PATCH 19/28] omap4: Fix McBSP4 base address Tony Lindgren
2010-04-23 23:11 ` [PATCH 20/28] omap: board-sdp-flash.c: Fix typos in debug output Tony Lindgren
2010-04-23 23:11 ` [PATCH 21/28] n8x0_defconfig: remove CONFIG_NILFS2_FS override Tony Lindgren
2010-04-23 23:11 ` [PATCH 22/28] omap: Devkit8000: Fix typo in supplies Tony Lindgren
2010-04-23 23:11 ` [PATCH 23/28] omap: Devkit8000: Add missing package selection Tony Lindgren
2010-04-23 23:12 ` [PATCH 24/28] omap: Devkit8000: Fix typo in pin name Tony Lindgren
2010-04-23 23:12 ` [PATCH 25/28] omap: Devkit8000: Remove unnecessary include file Tony Lindgren
2010-04-23 23:12 ` [PATCH 26/28] omap: Devkit8000: Change position of init calls Tony Lindgren
2010-04-23 23:12 ` [PATCH 27/28] omap: Devkit8000: Remove unused pins Tony Lindgren
2010-04-23 23:12 ` [PATCH 28/28] omap: delete unused bootloader tag variables Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423231120.31953.45582.stgit@baageli.muru.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).