From: sebastian@breakpoint.cc (Sebastian Andrzej Siewior)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net/ipsec: don't treat EINPROGRESS as a regular error
Date: Sat, 24 Apr 2010 16:42:15 +0200 [thread overview]
Message-ID: <20100424144215.GA9057@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <4BCE125F.30200@gmail.com>
a driver might drop EINPROGRESS because its internal queue is full and
not because something went wrong. In that case there will be another
call back invocation and the stack should not free the skb.
Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
---
net/xfrm/xfrm_output.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c
index 6a32915..34dd460 100644
--- a/net/xfrm/xfrm_output.c
+++ b/net/xfrm/xfrm_output.c
@@ -86,10 +86,10 @@ static int xfrm_output_one(struct sk_buff *skb, int err)
spin_unlock_bh(&x->lock);
err = x->type->output(x, skb);
+resume:
if (err == -EINPROGRESS)
goto out_exit;
-resume:
if (err) {
XFRM_INC_STATS(net, LINUX_MIB_XFRMOUTSTATEPROTOERROR);
goto error_nolock;
--
1.6.6.1
next prev parent reply other threads:[~2010-04-24 14:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4B12F9E7.1020207@gmail.com>
[not found] ` <20091130211531.GK18101@deprecation.cyrius.com>
[not found] ` <4B144627.7060901@gmail.com>
[not found] ` <20091204212847.GC28480@deprecation.cyrius.com>
2010-04-18 17:23 ` Bug#552270: Marvell CESA driver and Kirkwood L.C.
2010-04-18 19:17 ` Sebastian Andrzej Siewior
2010-04-19 23:11 ` L.C.
2010-04-20 20:45 ` L.C.
2010-04-21 8:13 ` Sebastian Andrzej Siewior
2010-04-22 3:23 ` Uri Simchoni
2010-04-24 15:12 ` Sebastian Andrzej Siewior
2010-04-24 15:13 ` Sebastian Andrzej Siewior
2010-04-24 18:43 ` Uri Simchoni
2010-04-30 9:20 ` Sebastian Andrzej Siewior
2010-04-24 14:42 ` Sebastian Andrzej Siewior [this message]
2010-04-25 1:18 ` [PATCH] net/ipsec: don't treat EINPROGRESS as a regular error Herbert Xu
2010-04-25 15:29 ` Sebastian Andrzej Siewior
2010-04-26 1:17 ` Herbert Xu
2010-04-26 18:11 ` Sebastian Andrzej Siewior
2010-04-27 1:35 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100424144215.GA9057@Chamillionaire.breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox