From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] S3C: DMA API: Change argument type of s3c2410_dma_devconfig
Date: Mon, 26 Apr 2010 05:25:49 +0100 [thread overview]
Message-ID: <20100426042549.GG28105@trinity.fluff.org> (raw)
In-Reply-To: <1271835549-31228-1-git-send-email-jassisinghbrar@gmail.com>
On Wed, Apr 21, 2010 at 04:39:09PM +0900, jassisinghbrar at gmail.com wrote:
> From: Jassi Brar <jassi.brar@samsung.com>
>
> All other functions have the channel argument of type 'unsigned int'
> the s3c2410_dma_devconfig also accept the same value as argument but
> treat it as type 'int'. Remove this anomaly by make it 'unsigned int'.
Looks fine.
> Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
> ---
> arch/arm/mach-s3c64xx/dma.c | 2 +-
> arch/arm/plat-s3c24xx/dma.c | 2 +-
> arch/arm/plat-samsung/include/plat/dma.h | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-s3c64xx/dma.c b/arch/arm/mach-s3c64xx/dma.c
> index b62bdf1..b4d6865 100644
> --- a/arch/arm/mach-s3c64xx/dma.c
> +++ b/arch/arm/mach-s3c64xx/dma.c
> @@ -413,7 +413,7 @@ err_buff:
> EXPORT_SYMBOL(s3c2410_dma_enqueue);
>
>
> -int s3c2410_dma_devconfig(int channel,
> +int s3c2410_dma_devconfig(unsigned int channel,
> enum s3c2410_dmasrc source,
> unsigned long devaddr)
> {
> diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c
> index 93827b3..6ad274e 100644
> --- a/arch/arm/plat-s3c24xx/dma.c
> +++ b/arch/arm/plat-s3c24xx/dma.c
> @@ -1104,7 +1104,7 @@ EXPORT_SYMBOL(s3c2410_dma_config);
> * devaddr: physical address of the source
> */
>
> -int s3c2410_dma_devconfig(int channel,
> +int s3c2410_dma_devconfig(unsigned int channel,
> enum s3c2410_dmasrc source,
> unsigned long devaddr)
> {
> diff --git a/arch/arm/plat-samsung/include/plat/dma.h b/arch/arm/plat-samsung/include/plat/dma.h
> index 7584d75..2e8f8c6 100644
> --- a/arch/arm/plat-samsung/include/plat/dma.h
> +++ b/arch/arm/plat-samsung/include/plat/dma.h
> @@ -110,8 +110,8 @@ extern int s3c2410_dma_config(unsigned int channel, int xferunit);
> * configure the device we're talking to
> */
>
> -extern int s3c2410_dma_devconfig(int channel, enum s3c2410_dmasrc source,
> - unsigned long devaddr);
> +extern int s3c2410_dma_devconfig(unsigned int channel,
> + enum s3c2410_dmasrc source, unsigned long devaddr);
>
> /* s3c2410_dma_getposition
> *
> --
> 1.6.2.5
>
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
prev parent reply other threads:[~2010-04-26 4:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 7:39 [PATCH 2/7] S3C: DMA API: Change argument type of s3c2410_dma_devconfig jassisinghbrar at gmail.com
2010-04-26 4:25 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100426042549.GG28105@trinity.fluff.org \
--to=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).