* [PATCH 2/7] S3C: DMA API: Change argument type of s3c2410_dma_devconfig
@ 2010-04-21 7:39 jassisinghbrar at gmail.com
2010-04-26 4:25 ` Ben Dooks
0 siblings, 1 reply; 2+ messages in thread
From: jassisinghbrar at gmail.com @ 2010-04-21 7:39 UTC (permalink / raw)
To: linux-arm-kernel
From: Jassi Brar <jassi.brar@samsung.com>
All other functions have the channel argument of type 'unsigned int'
the s3c2410_dma_devconfig also accept the same value as argument but
treat it as type 'int'. Remove this anomaly by make it 'unsigned int'.
Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
---
arch/arm/mach-s3c64xx/dma.c | 2 +-
arch/arm/plat-s3c24xx/dma.c | 2 +-
arch/arm/plat-samsung/include/plat/dma.h | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-s3c64xx/dma.c b/arch/arm/mach-s3c64xx/dma.c
index b62bdf1..b4d6865 100644
--- a/arch/arm/mach-s3c64xx/dma.c
+++ b/arch/arm/mach-s3c64xx/dma.c
@@ -413,7 +413,7 @@ err_buff:
EXPORT_SYMBOL(s3c2410_dma_enqueue);
-int s3c2410_dma_devconfig(int channel,
+int s3c2410_dma_devconfig(unsigned int channel,
enum s3c2410_dmasrc source,
unsigned long devaddr)
{
diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c
index 93827b3..6ad274e 100644
--- a/arch/arm/plat-s3c24xx/dma.c
+++ b/arch/arm/plat-s3c24xx/dma.c
@@ -1104,7 +1104,7 @@ EXPORT_SYMBOL(s3c2410_dma_config);
* devaddr: physical address of the source
*/
-int s3c2410_dma_devconfig(int channel,
+int s3c2410_dma_devconfig(unsigned int channel,
enum s3c2410_dmasrc source,
unsigned long devaddr)
{
diff --git a/arch/arm/plat-samsung/include/plat/dma.h b/arch/arm/plat-samsung/include/plat/dma.h
index 7584d75..2e8f8c6 100644
--- a/arch/arm/plat-samsung/include/plat/dma.h
+++ b/arch/arm/plat-samsung/include/plat/dma.h
@@ -110,8 +110,8 @@ extern int s3c2410_dma_config(unsigned int channel, int xferunit);
* configure the device we're talking to
*/
-extern int s3c2410_dma_devconfig(int channel, enum s3c2410_dmasrc source,
- unsigned long devaddr);
+extern int s3c2410_dma_devconfig(unsigned int channel,
+ enum s3c2410_dmasrc source, unsigned long devaddr);
/* s3c2410_dma_getposition
*
--
1.6.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/7] S3C: DMA API: Change argument type of s3c2410_dma_devconfig
2010-04-21 7:39 [PATCH 2/7] S3C: DMA API: Change argument type of s3c2410_dma_devconfig jassisinghbrar at gmail.com
@ 2010-04-26 4:25 ` Ben Dooks
0 siblings, 0 replies; 2+ messages in thread
From: Ben Dooks @ 2010-04-26 4:25 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Apr 21, 2010 at 04:39:09PM +0900, jassisinghbrar at gmail.com wrote:
> From: Jassi Brar <jassi.brar@samsung.com>
>
> All other functions have the channel argument of type 'unsigned int'
> the s3c2410_dma_devconfig also accept the same value as argument but
> treat it as type 'int'. Remove this anomaly by make it 'unsigned int'.
Looks fine.
> Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
> ---
> arch/arm/mach-s3c64xx/dma.c | 2 +-
> arch/arm/plat-s3c24xx/dma.c | 2 +-
> arch/arm/plat-samsung/include/plat/dma.h | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-s3c64xx/dma.c b/arch/arm/mach-s3c64xx/dma.c
> index b62bdf1..b4d6865 100644
> --- a/arch/arm/mach-s3c64xx/dma.c
> +++ b/arch/arm/mach-s3c64xx/dma.c
> @@ -413,7 +413,7 @@ err_buff:
> EXPORT_SYMBOL(s3c2410_dma_enqueue);
>
>
> -int s3c2410_dma_devconfig(int channel,
> +int s3c2410_dma_devconfig(unsigned int channel,
> enum s3c2410_dmasrc source,
> unsigned long devaddr)
> {
> diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c
> index 93827b3..6ad274e 100644
> --- a/arch/arm/plat-s3c24xx/dma.c
> +++ b/arch/arm/plat-s3c24xx/dma.c
> @@ -1104,7 +1104,7 @@ EXPORT_SYMBOL(s3c2410_dma_config);
> * devaddr: physical address of the source
> */
>
> -int s3c2410_dma_devconfig(int channel,
> +int s3c2410_dma_devconfig(unsigned int channel,
> enum s3c2410_dmasrc source,
> unsigned long devaddr)
> {
> diff --git a/arch/arm/plat-samsung/include/plat/dma.h b/arch/arm/plat-samsung/include/plat/dma.h
> index 7584d75..2e8f8c6 100644
> --- a/arch/arm/plat-samsung/include/plat/dma.h
> +++ b/arch/arm/plat-samsung/include/plat/dma.h
> @@ -110,8 +110,8 @@ extern int s3c2410_dma_config(unsigned int channel, int xferunit);
> * configure the device we're talking to
> */
>
> -extern int s3c2410_dma_devconfig(int channel, enum s3c2410_dmasrc source,
> - unsigned long devaddr);
> +extern int s3c2410_dma_devconfig(unsigned int channel,
> + enum s3c2410_dmasrc source, unsigned long devaddr);
>
> /* s3c2410_dma_getposition
> *
> --
> 1.6.2.5
>
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-26 4:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-21 7:39 [PATCH 2/7] S3C: DMA API: Change argument type of s3c2410_dma_devconfig jassisinghbrar at gmail.com
2010-04-26 4:25 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).