From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [2.6.34-rc6] ARM: build breaks with KPROBES
Date: Fri, 30 Apr 2010 08:47:45 +0100 [thread overview]
Message-ID: <20100430074745.GA7874@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <EAF47CD23C76F840A9E7FCE10091EFAB02C52179C0@dbde02.ent.ti.com>
On Fri, Apr 30, 2010 at 12:51:49PM +0530, Shilimkar, Santosh wrote:
> Russell,
>
> The latest mainline ARM build breaks with KPROBES enabled. Anand
> Gadiyar did git bisect and figured out that below commit breaks the build.
> commit :4260415f6a3b92c5c986398d96c314df37a4ccbf
Did you read the comments in the commit message to understand why
.previous is dangerous?
> I tried matching the sections but failed to fix the build error. Below
> is the hack patch to keep build working.
The previous section is not .text, but:
#ifdef CONFIG_KPROBES
.section .kprobes.text,"ax",%progbits
#else
.text
#endif
Either change the preceding .data to .pushsection .data, and the following
.text to .popsection, or duplicate the above ifdef; .pushsection/.popsection
is _far_ safer than using .previous.
next prev parent reply other threads:[~2010-04-30 7:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 7:21 [2.6.34-rc6] ARM: build breaks with KPROBES Shilimkar, Santosh
2010-04-30 7:47 ` Russell King - ARM Linux [this message]
2010-04-30 9:27 ` Shilimkar, Santosh
2010-04-30 9:37 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100430074745.GA7874@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).