[PATCH] ARM: Add support for 10 hardirq bits

[PATCH] ARM: Add support for 10 hardirq bits

[Magnus Damm]

From: Magnus Damm <damm@opensource.se>

This patch adds support for 10 hardirq bits to
the ARM architecture. Needed by the SH-Mobile
ARM processor sh7372 that has more than 512 IRQs.

Signed-off-by: Magnus Damm <damm@opensource.se>
---

 arch/arm/include/asm/hardirq.h |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- 0001/arch/arm/include/asm/hardirq.h
+++ work/arch/arm/include/asm/hardirq.h	2010-03-09 21:08:10.000000000 +0900
@@ -12,7 +12,9 @@ typedef struct {
 
 #include <linux/irq_cpustat.h>	/* Standard mappings for irq_cpustat_t above */
 
-#if NR_IRQS > 256
+#if NR_IRQS > 512
+#define HARDIRQ_BITS	10
+#elif NR_IRQS > 256
 #define HARDIRQ_BITS	9
 #else
 #define HARDIRQ_BITS	8

[PATCH] ARM: Add support for 10 hardirq bits

[Magnus Damm]

On Wed, Mar 10, 2010 at 8:17 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> From: Magnus Damm <damm@opensource.se>
>
> This patch adds support for 10 hardirq bits to
> the ARM architecture. Needed by the SH-Mobile
> ARM processor sh7372 that has more than 512 IRQs.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
>
> ?arch/arm/include/asm/hardirq.h | ? ?4 +++-
> ?1 file changed, 3 insertions(+), 1 deletion(-)
>
> --- 0001/arch/arm/include/asm/hardirq.h
> +++ work/arch/arm/include/asm/hardirq.h 2010-03-09 21:08:10.000000000 +0900
> @@ -12,7 +12,9 @@ typedef struct {
>
> ?#include <linux/irq_cpustat.h> /* Standard mappings for irq_cpustat_t above */
>
> -#if NR_IRQS > 256
> +#if NR_IRQS > 512
> +#define HARDIRQ_BITS ? 10
> +#elif NR_IRQS > 256
> ?#define HARDIRQ_BITS ? 9
> ?#else
> ?#define HARDIRQ_BITS ? 8
>

Hi Russell,

Good to hear that you are back online. Do you want me to rework this
patch somehow, or is it ready to be queued for upstream merge? I'm
asking because I have a pile of patches that depend on this one.

Cheers,

/ magnus

[PATCH] ARM: Add support for 10 hardirq bits

[Russell King - ARM Linux]

On Fri, Apr 30, 2010 at 01:02:04PM +0900, Magnus Damm wrote:
> On Wed, Mar 10, 2010 at 8:17 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> > From: Magnus Damm <damm@opensource.se>
> >
> > This patch adds support for 10 hardirq bits to
> > the ARM architecture. Needed by the SH-Mobile
> > ARM processor sh7372 that has more than 512 IRQs.
> >
> > Signed-off-by: Magnus Damm <damm@opensource.se>
> > ---
> >
> > ?arch/arm/include/asm/hardirq.h | ? ?4 +++-
> > ?1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > --- 0001/arch/arm/include/asm/hardirq.h
> > +++ work/arch/arm/include/asm/hardirq.h 2010-03-09 21:08:10.000000000 +0900
> > @@ -12,7 +12,9 @@ typedef struct {
> >
> > ?#include <linux/irq_cpustat.h> /* Standard mappings for irq_cpustat_t above */
> >
> > -#if NR_IRQS > 256
> > +#if NR_IRQS > 512
> > +#define HARDIRQ_BITS ? 10
> > +#elif NR_IRQS > 256
> > ?#define HARDIRQ_BITS ? 9
> > ?#else
> > ?#define HARDIRQ_BITS ? 8
> >
> 
> Hi Russell,
> 
> Good to hear that you are back online. Do you want me to rework this
> patch somehow, or is it ready to be queued for upstream merge? I'm
> asking because I have a pile of patches that depend on this one.

I guess it's ok; with 10 bits we're at the maximum which the generic
kernel supports (see linux/hardirq.h)

[PATCH] ARM: Add support for 10 hardirq bits

[Magnus Damm]

On Sat, May 1, 2010 at 6:44 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Fri, Apr 30, 2010 at 01:02:04PM +0900, Magnus Damm wrote:
>> On Wed, Mar 10, 2010 at 8:17 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> > From: Magnus Damm <damm@opensource.se>
>> >
>> > This patch adds support for 10 hardirq bits to
>> > the ARM architecture. Needed by the SH-Mobile
>> > ARM processor sh7372 that has more than 512 IRQs.
>> >
>> > Signed-off-by: Magnus Damm <damm@opensource.se>
>> > ---
>> >
>
> I guess it's ok; with 10 bits we're at the maximum which the generic
> kernel supports (see linux/hardirq.h)

Hi again Russell,

Will you pick up this one in your tree as-is, or would you like me to
resubmit it somehow?

Perhaps you prefer that we take it with the other changes through the
genesis-2.6 tree?

Sorry to bother you if this has already been sorted. I just noticed
that the patch isn't part of the latest linux-next.

Thanks,

/ magnus

[PATCH] ARM: Add support for 10 hardirq bits

[Eric Miao]

On Thu, May 13, 2010 at 3:30 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> On Sat, May 1, 2010 at 6:44 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
>> On Fri, Apr 30, 2010 at 01:02:04PM +0900, Magnus Damm wrote:
>>> On Wed, Mar 10, 2010 at 8:17 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>> > From: Magnus Damm <damm@opensource.se>
>>> >
>>> > This patch adds support for 10 hardirq bits to
>>> > the ARM architecture. Needed by the SH-Mobile
>>> > ARM processor sh7372 that has more than 512 IRQs.
>>> >
>>> > Signed-off-by: Magnus Damm <damm@opensource.se>
>>> > ---
>>> >
>>
>> I guess it's ok; with 10 bits we're at the maximum which the generic
>> kernel supports (see linux/hardirq.h)
>
> Hi again Russell,
>
> Will you pick up this one in your tree as-is, or would you like me to
> resubmit it somehow?
>

Russell,

I don't seem to find this patch in your -devel branch. I posted a same
version of patch earlier, so I'd also like to see this get merged.

Acked-by: Eric Miao <eric.y.miao@gmail.com>

Magnus,

I guess you may please help submit this to rmk's patch tracking system?

[PATCH] ARM: Add support for 10 hardirq bits

[Russell King - ARM Linux]

On Wed, May 19, 2010 at 03:16:32PM +0800, Eric Miao wrote:
> On Thu, May 13, 2010 at 3:30 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> > Hi again Russell,
> >
> > Will you pick up this one in your tree as-is, or would you like me to
> > resubmit it somehow?
> >
> 
> Russell,
> 
> I don't seem to find this patch in your -devel branch. I posted a same
> version of patch earlier, so I'd also like to see this get merged.
> 
> Acked-by: Eric Miao <eric.y.miao@gmail.com>
> 
> Magnus,
> 
> I guess you may please help submit this to rmk's patch tracking system?

Getting it into the patch system would be a big help, but since I've
closed my tree down for this merge window already, it's missed the
boat.  (With Linus' new "random" behaviour wrt when things happen, I'm
not planning on a second ARM kernel pull request - and the first was
sent last night.)

This is probably the patch I was referring to in my notice of closure
when I said:
| I know there was someone who was complaining a week or so ago that I
| hadn't applied their patch, which was only sent to the mailing list.
| Unfortunately, it being only on the mailing list and not in the patch
| system means I can't find it, nor the complaint about it not being
| applied.
|
| Whoever it was, sorry.

Especially as it's 4000 messages back in this mailbox!

[PATCH] ARM: Add support for 10 hardirq bits

[Magnus Damm]

On Wed, May 19, 2010 at 4:16 PM, Eric Miao <eric.y.miao@gmail.com> wrote:
> On Thu, May 13, 2010 at 3:30 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> On Sat, May 1, 2010 at 6:44 PM, Russell King - ARM Linux
>> <linux@arm.linux.org.uk> wrote:
>>> On Fri, Apr 30, 2010 at 01:02:04PM +0900, Magnus Damm wrote:
>>>> On Wed, Mar 10, 2010 at 8:17 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>>> > From: Magnus Damm <damm@opensource.se>
>>>> >
>>>> > This patch adds support for 10 hardirq bits to
>>>> > the ARM architecture. Needed by the SH-Mobile
>>>> > ARM processor sh7372 that has more than 512 IRQs.
>>>> >
>>>> > Signed-off-by: Magnus Damm <damm@opensource.se>
>>>> > ---
>>>> >
>>>
>>> I guess it's ok; with 10 bits we're at the maximum which the generic
>>> kernel supports (see linux/hardirq.h)
>>
>> Hi again Russell,
>>
>> Will you pick up this one in your tree as-is, or would you like me to
>> resubmit it somehow?
>>
>
> Russell,
>
> I don't seem to find this patch in your -devel branch. I posted a same
> version of patch earlier, so I'd also like to see this get merged.
>
> Acked-by: Eric Miao <eric.y.miao@gmail.com>

Thanks, Eric!

> Magnus,
>
> I guess you may please help submit this to rmk's patch tracking system?

I've been trying to, but I guess I must have formatted it incorrectly
since I don't hear anything back from the mail robot.

/ magnus

[PATCH] ARM: Add support for 10 hardirq bits

[Magnus Damm]

Hi Russell,

On Wed, May 19, 2010 at 5:37 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Wed, May 19, 2010 at 03:16:32PM +0800, Eric Miao wrote:
>> On Thu, May 13, 2010 at 3:30 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> > Hi again Russell,
>> >
>> > Will you pick up this one in your tree as-is, or would you like me to
>> > resubmit it somehow?
>> >
>>
>> Russell,
>>
>> I don't seem to find this patch in your -devel branch. I posted a same
>> version of patch earlier, so I'd also like to see this get merged.
>>
>> Acked-by: Eric Miao <eric.y.miao@gmail.com>
>>
>> Magnus,
>>
>> I guess you may please help submit this to rmk's patch tracking system?
>
> Getting it into the patch system would be a big help, but since I've
> closed my tree down for this merge window already, it's missed the
> boat. ?(With Linus' new "random" behaviour wrt when things happen, I'm
> not planning on a second ARM kernel pull request - and the first was
> sent last night.)

It's there now:

http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6138/1

Anything I can do to make a second pull request happen? There are
quite a few patches that depend on this one, so I posted it well in
advace at March 10. The patch was kindly reviewed by you a bit later.
And now I got an ack. Unfortunately I didn't proceed and submit it to
the ARM-specific patch tracking system.

> This is probably the patch I was referring to in my notice of closure
> when I said:
> | I know there was someone who was complaining a week or so ago that I
> | hadn't applied their patch, which was only sent to the mailing list.
> | Unfortunately, it being only on the mailing list and not in the patch
> | system means I can't find it, nor the complaint about it not being
> | applied.
> |
> | Whoever it was, sorry.
>
> Especially as it's 4000 messages back in this mailbox!

Sounds painful. =)

Thanks for your help!

/ magnus

[PATCH] ARM: Add support for 10 hardirq bits

[Eric Miao]

>> This is probably the patch I was referring to in my notice of closure
>> when I said:
>> | I know there was someone who was complaining a week or so ago that I
>> | hadn't applied their patch, which was only sent to the mailing list.
>> | Unfortunately, it being only on the mailing list and not in the patch
>> | system means I can't find it, nor the complaint about it not being
>> | applied.
>> |
>> | Whoever it was, sorry.
>>
>> Especially as it's 4000 messages back in this mailbox!
>
> Sounds painful. =)
>

I don't mean to push, and I fully understand that workload due to such a
short -rc phase this time. Just wondering this can actually be made into
the .35-rc phase?