linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/8] ARM: Implement read/write for ownership in the ARMv6 DMA cache ops
Date: Tue, 04 May 2010 17:44:26 +0100	[thread overview]
Message-ID: <20100504164426.26355.19161.stgit@e102109-lin.cambridge.arm.com> (raw)
In-Reply-To: <20100504163823.26355.58568.stgit@e102109-lin.cambridge.arm.com>

The Snoop Control Unit on the ARM11MPCore hardware does not detect the
cache operations and the dma_cache_maint*() functions may leave stale
cache entries on other CPUs. The solution implemented in this patch
performs a Read or Write For Ownership in the ARMv6 DMA cache
maintenance functions. These LDR/STR instructions change the cache line
state to shared or exclusive so that the cache maintenance operation has
the desired effect.

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
---
 arch/arm/mm/cache-v6.S |   17 +++++++++++++----
 1 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mm/cache-v6.S b/arch/arm/mm/cache-v6.S
index 9d89c67..e46ecd8 100644
--- a/arch/arm/mm/cache-v6.S
+++ b/arch/arm/mm/cache-v6.S
@@ -211,6 +211,9 @@ v6_dma_inv_range:
 	mcrne	p15, 0, r1, c7, c15, 1		@ clean & invalidate unified line
 #endif
 1:
+#ifdef CONFIG_SMP
+	str	r0, [r0]			@ write for ownership
+#endif
 #ifdef HARVARD_CACHE
 	mcr	p15, 0, r0, c7, c6, 1		@ invalidate D line
 #else
@@ -231,6 +234,9 @@ v6_dma_inv_range:
 v6_dma_clean_range:
 	bic	r0, r0, #D_CACHE_LINE_SIZE - 1
 1:
+#ifdef CONFIG_SMP
+	ldr	r2, [r0]			@ read for ownership
+#endif
 #ifdef HARVARD_CACHE
 	mcr	p15, 0, r0, c7, c10, 1		@ clean D line
 #else
@@ -251,6 +257,10 @@ v6_dma_clean_range:
 ENTRY(v6_dma_flush_range)
 	bic	r0, r0, #D_CACHE_LINE_SIZE - 1
 1:
+#ifdef CONFIG_SMP
+	ldr	r2, [r0]			@ read for ownership
+	str	r2, [r0]			@ write for ownership
+#endif
 #ifdef HARVARD_CACHE
 	mcr	p15, 0, r0, c7, c14, 1		@ clean & invalidate D line
 #else
@@ -273,7 +283,9 @@ ENTRY(v6_dma_map_area)
 	add	r1, r1, r0
 	teq	r2, #DMA_FROM_DEVICE
 	beq	v6_dma_inv_range
-	b	v6_dma_clean_range
+	teq	r2, #DMA_TO_DEVICE
+	beq	v6_dma_clean_range
+	b	v6_dma_flush_range
 ENDPROC(v6_dma_map_area)
 
 /*
@@ -283,9 +295,6 @@ ENDPROC(v6_dma_map_area)
  *	- dir	- DMA direction
  */
 ENTRY(v6_dma_unmap_area)
-	add	r1, r1, r0
-	teq	r2, #DMA_TO_DEVICE
-	bne	v6_dma_inv_range
 	mov	pc, lr
 ENDPROC(v6_dma_unmap_area)
 

  parent reply	other threads:[~2010-05-04 16:44 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-04 16:44 [PATCH 0/8] Various patches for comments and upstream Catalin Marinas
2010-05-04 16:44 ` [PATCH 1/8] ARM: Improve the L2 cache performance when PL310 is used Catalin Marinas
2010-05-04 17:02   ` Jason McMullan
2010-05-05 16:07     ` Catalin Marinas
2010-05-04 16:44 ` Catalin Marinas [this message]
2010-05-04 17:04   ` [PATCH 2/8] ARM: Implement read/write for ownership in the ARMv6 DMA cache ops Jason McMullan
2010-05-05 16:23     ` Catalin Marinas
2010-05-05 13:26   ` George G. Davis
2010-05-06 14:40     ` Catalin Marinas
2010-05-06 15:57       ` George G. Davis
2010-05-12 12:51   ` Ronen Shitrit
2010-05-12 13:55     ` Catalin Marinas
2010-05-12 15:03       ` Ronen Shitrit
2010-05-12 18:48       ` Russell King - ARM Linux
2010-05-12 18:59         ` Russell King - ARM Linux
2010-05-12 20:00           ` Ronen Shitrit
2010-05-12 20:04             ` Russell King - ARM Linux
2010-05-12 20:19               ` Ronen Shitrit
2010-05-12 21:21           ` [PATCH 2/8] ARM: Implement read/write for ownership in theARMv6 " Catalin Marinas
2010-05-13  5:27             ` Ronen Shitrit
2010-05-13  8:26               ` Catalin Marinas
2010-05-13 13:54                 ` George G. Davis
2010-05-13 14:15                   ` Catalin Marinas
2010-05-13 20:34                     ` George G. Davis
2010-05-14 16:29                       ` Catalin Marinas
2010-05-14 16:42                         ` Catalin Marinas
2010-05-15  1:26                           ` George G. Davis
2010-05-16  6:28                             ` Ronen Shitrit
2010-05-16  6:29                 ` Ronen Shitrit
2010-05-16 15:01                   ` Russell King - ARM Linux
2010-05-17  6:29                     ` Ronen Shitrit
2010-05-17  6:57                       ` Russell King - ARM Linux
2010-05-17  7:34                         ` Ronen Shitrit
2010-05-17  7:43                           ` Russell King - ARM Linux
2010-05-17  8:29                             ` Ronen Shitrit
2010-05-17  8:57                               ` Russell King - ARM Linux
2010-05-17  9:50                                 ` Ronen Shitrit
2010-05-17 10:03                                   ` Russell King - ARM Linux
2010-05-17 11:26                                     ` Ronen Shitrit
2010-05-17 11:31                                       ` Russell King - ARM Linux
2010-05-17 11:45                                         ` Catalin Marinas
2010-05-17 10:00                           ` Catalin Marinas
2010-05-17 11:29                             ` Ronen Shitrit
2010-05-17 11:42                               ` Catalin Marinas
2010-05-17 12:04                                 ` Ronen Shitrit
2010-05-17 13:45                                   ` Catalin Marinas
2010-05-17  9:51                   ` Catalin Marinas
2010-05-17  9:57                     ` Catalin Marinas
2010-05-17  9:59                       ` Ronen Shitrit
2010-05-17 11:08                         ` Catalin Marinas
2010-05-17 11:27                           ` Ronen Shitrit
2010-05-17 11:47                             ` Catalin Marinas
2010-05-17 13:46                               ` [PATCH 2/8] ARM: Implement read/write for ownership intheARMv6 " Catalin Marinas
2010-05-04 16:44 ` [PATCH 3/8] ARM: Align machine_desc.phys_io to a 1MB section Catalin Marinas
2010-05-04 16:44 ` [PATCH 4/8] ARM: Remove the domain switching on ARMv6k/v7 CPUs Catalin Marinas
2010-05-04 16:44 ` [PATCH 5/8] ARM: Fix the __arm_ioremap_caller() definition in nommu.c Catalin Marinas
2010-05-04 17:19   ` Russell King - ARM Linux
2010-05-04 16:44 ` [PATCH 6/8] ARM: Implement copy_to_user_page() for noMMU Catalin Marinas
2010-05-04 17:19   ` Russell King - ARM Linux
2010-05-04 16:44 ` [PATCH 7/8] ARM: Use the Inner Shareable I-cache and BTB ops on ARMv7 SMP Catalin Marinas
2010-05-28 18:50   ` Russell King - ARM Linux
2010-05-28 21:37     ` [PATCH 7/8] ARM: Use the Inner Shareable I-cache and BTB opson " Catalin Marinas
2010-05-04 16:44 ` [PATCH 8/8] ARM: Implement phys_mem_access_prot() to avoid attributes aliasing Catalin Marinas
2010-05-04 16:48 ` [PATCH 0/8] Various patches for comments and upstream Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100504164426.26355.19161.stgit@e102109-lin.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).