linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [at91] Save power by disabling the processor clock when CPU is idle
Date: Wed, 5 May 2010 22:25:29 +0200	[thread overview]
Message-ID: <20100505202529.GB25037@pengutronix.de> (raw)
In-Reply-To: <1271156732l.25331l.7l@i-dmzi_al.realan.de>

Hello,

On Tue, Apr 13, 2010 at 01:05:32PM +0200, Anders Larsen wrote:
> Disable the processor clock when the CPU is idle.
> 
> This saves much more power than merely entering 'Wait for Interrupt' mode.
> Since JTAG-debugging doesn't work when the processor clock is switched off,
> make it conditional on CONFIG_DEBUG_KERNEL.
> 
> Signed-off-by: Anders Larsen <al@alarsen.net>
> Cc: Andrew Victor <avictor.za@gmail.com>
> ---
> KernelVersion: 2.6.33
> 
>  arch/arm/mach-at91/include/mach/system.h |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> 
> Index: b/arch/arm/mach-at91/include/mach/system.h
> ===================================================================
> --- a/arch/arm/mach-at91/include/mach/system.h
> +++ b/arch/arm/mach-at91/include/mach/system.h
> @@ -24,21 +24,24 @@
>  #include <mach/hardware.h>
>  #include <mach/at91_st.h>
>  #include <mach/at91_dbgu.h>
> +#include <mach/at91_pmc.h>
>  
>  static inline void arch_idle(void)
>  {
> +#ifndef CONFIG_DEBUG_KERNEL
>  	/*
>  	 * Disable the processor clock.  The processor will be automatically
>  	 * re-enabled by an interrupt or by a reset.
>  	 */
> -//	at91_sys_write(AT91_PMC_SCDR, AT91_PMC_PCK);
> -
> +	at91_sys_write(AT91_PMC_SCDR, AT91_PMC_PCK);
> +#else
>  	/*
>  	 * Set the processor (CP15) into 'Wait for Interrupt' mode.
>  	 * Unlike disabling the processor clock via the PMC (above)
>  	 *  this allows the processor to be woken via JTAG.
>  	 */
>  	cpu_do_idle();
> +#endif

There is a kernel parameter (IIRC "nohlt") that should take care of
this?!

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  parent reply	other threads:[~2010-05-05 20:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-13 11:05 [at91] Save power by disabling the processor clock when CPU is idle Anders Larsen
2010-05-02 20:10 ` avictor.za at gmail.com
2010-05-02 22:34   ` Russell King - ARM Linux
2010-05-05  8:05     ` avictor.za at gmail.com
2010-05-05 20:25 ` Uwe Kleine-König [this message]
2010-05-06  8:36   ` Anders Larsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100505202529.GB25037@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).