From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: arm926_dma_flush_range undefined!
Date: Thu, 6 May 2010 18:59:07 +0100 [thread overview]
Message-ID: <20100506175907.GA15797@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1273154831.2094.11.camel@e102109-lin.cambridge.arm.com>
On Thu, May 06, 2010 at 03:07:11PM +0100, Catalin Marinas wrote:
> On Thu, 2010-05-06 at 15:11 +0200, Nicolas Ferre wrote:
> > I am trying to compile a recent kernel
> > (v2.6.34-rc6-201-g722154e) and I am
> > having this kind of error:
> >
> > ERROR: "arm926_dma_flush_range" [drivers/mmc/host/at91_mci.ko] undefined!
>
> The driver seems to use dmac_flush_range() directly. That's not part of
> the DMA API. Could you not use one of the supported DMA API functions?
Indeed; I've always said that I don't care about drivers directly using
the internals of the DMA API, and drivers doing this will be constantly
subjected to breakage.
I really do not regard the above to be a regression; it's a latent
programming error. AT91 folk need to fix their driver(s) to use the
proper interfaces rather than using internal functionality.
next prev parent reply other threads:[~2010-05-06 17:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 13:11 arm926_dma_flush_range undefined! Nicolas Ferre
2010-05-06 14:07 ` Catalin Marinas
2010-05-06 17:59 ` Russell King - ARM Linux [this message]
2010-05-11 9:43 ` Nicolas Ferre
2010-05-11 9:44 ` Russell King - ARM Linux
2010-05-11 13:32 ` Nicolas Ferre
2010-05-11 13:44 ` Russell King - ARM Linux
2010-05-11 17:09 ` [PATCH] MMC: at91_mci: modify cache flush routines Nicolas Ferre
2010-05-12 21:19 ` Andrew Morton
2010-05-12 21:30 ` Russell King - ARM Linux
2010-05-19 11:04 ` Nicolas Ferre
2010-05-12 11:18 ` arm926_dma_flush_range undefined! Catalin Marinas
2010-05-12 18:42 ` Russell King - ARM Linux
2010-05-12 21:39 ` Catalin Marinas
2010-05-12 6:48 ` Wolfgang Mües
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506175907.GA15797@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).