From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv5 0/3] Introduce the /proc/socinfo and use it to export OMAP data
Date: Wed, 12 May 2010 15:24:24 -0700 [thread overview]
Message-ID: <20100512152424.803ea807.akpm@linux-foundation.org> (raw)
In-Reply-To: <1273587331-24604-1-git-send-email-eduardo.valentin@nokia.com>
On Tue, 11 May 2010 17:15:28 +0300
Eduardo Valentin <eduardo.valentin@nokia.com> wrote:
> Here is the version 5 of the change to export OMAP data to userspace
> (name, revision, id code, production id and die id).
>
> Basically, this version is still attempting to create a new file under /proc.
> It is the /proc/socinfo, which should be used to export bits which are SoC specific
> (not CPU related, nor machine related).
>
> So, differences between previous version are:
> - merged patch 02/04 with 03/04 to avoid compilation breakages.
> - simplified the seq_file usage by using the single_open and single_release functions
> - exported a function to register a seq_operation .show callback
> - adapted the changes accordingly
>
> As usual, comments are welcome.
This changelog would be rather more useful if it was to show us some
sample output from /proc/socinfo, perhaps accompanied with an
explanation for people who aren't familar with this area of the kernel.
I'd have thought that sysfs was an appropriate place for this info.
Perhaps under /sys/devices/platform? Or /sys/devices/system? Peter's
original patch didn't tell us where in the hierarchy the file was
placed, nor why it was placed there, not what its contents look like.
But crappy changelogs are the norm :(
The objections stated in this email:
http://www.mail-archive.com/linux-omap at vger.kernel.org/msg17630.html
appear to still apply to this version of the patches?
Kevin didn't explain why he said "Please export these via debugfs".
Tony didn't clearly explain why he said "I don't think we want to
export unique chip identifiers by default".
So apart from having certain opinions regarding communication skills
and wondering why people cc me on stuff without vaguely providing
enough info for me to understand what they're thinking, I don't know
what to make of it all :(
next prev parent reply other threads:[~2010-05-12 22:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 14:15 [PATCHv5 0/3] Introduce the /proc/socinfo and use it to export OMAP data Eduardo Valentin
2010-05-11 14:15 ` [PATCHv5 1/3] procfs: Introduce socinfo under /proc Eduardo Valentin
2010-05-11 14:15 ` [PATCHv5 2/3] OMAP: export OMAP info under /proc/socinfo Eduardo Valentin
2010-05-11 14:28 ` Nishanth Menon
2010-05-11 16:58 ` Eduardo Valentin
2010-05-12 12:34 ` Eduardo Valentin
2010-05-12 12:36 ` Nishanth Menon
2010-05-11 14:15 ` [PATCHv5 3/3] OMAP3: export chip IDCODE, Production ID and Die ID Eduardo Valentin
2010-05-12 22:24 ` Andrew Morton [this message]
2010-05-14 8:24 ` [PATCHv5 0/3] Introduce the /proc/socinfo and use it to export OMAP data Eduardo Valentin
2010-05-14 16:27 ` Tony Lindgren
2011-02-15 12:58 ` Linus Walleij
2011-02-16 11:57 ` Eduardo Valentin
2011-02-28 10:28 ` Maxime Coquelin
2011-03-01 4:51 ` Saravana Kannan
2011-03-02 1:13 ` Andrei Warkentin
2011-03-02 1:19 ` Saravana Kannan
2011-03-02 1:27 ` Ryan Mallon
2011-03-02 1:39 ` Saravana Kannan
2011-03-02 1:51 ` Ryan Mallon
2011-03-02 2:23 ` Saravana Kannan
2011-03-02 2:41 ` Ryan Mallon
2011-03-02 2:55 ` Saravana Kannan
2011-03-02 3:11 ` Ryan Mallon
2011-03-02 3:21 ` Saravana Kannan
2011-03-02 3:35 ` Ryan Mallon
2011-03-02 3:46 ` Saravana Kannan
2011-03-02 3:54 ` Ryan Mallon
2011-03-02 8:50 ` Maxime Coquelin
2011-03-02 20:09 ` Ryan Mallon
2011-03-02 8:23 ` Maxime Coquelin
2011-03-02 10:36 ` Linus Walleij
2011-03-02 10:53 ` Maxime Coquelin
2011-03-03 5:55 ` Saravana Kannan
2011-03-02 11:38 ` Jamie Iles
2011-03-02 12:17 ` Maxime Coquelin
2011-03-02 14:42 ` Linus Walleij
2011-03-02 15:18 ` Jamie Iles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100512152424.803ea807.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).