linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: rubini@unipv.it (Alessandro Rubini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] nomadik hwrng: Add clock support
Date: Wed, 12 May 2010 23:08:46 +0200	[thread overview]
Message-ID: <20100512210846.GA19831@morgana.i.gnudd.com> (raw)
In-Reply-To: <1273697274.15067.1136.camel@calx>

> Looks good to me. Herbert, please queue this.

There are two details wrong, I hope Srinidhi sent V2 soon after this V1.

>> +struct clk *rng_clk;

This should be static.

The other problem is that there is no clock associated to this device,
it is only added by the later 2/2 patch.  So the rng stops working
with this patch alone, with this error:

>> +	rng_clk = clk_get(&dev->dev, NULL);
>> +	if (IS_ERR(rng_clk)) {
>> +		dev_err(&dev->dev, "could not get rng clock\n");
>> +		ret = PTR_ERR(rng_clk);
>> +		return ret;
>> +	}

I think the two patches  must be split differently. However, it's just
two minor details, so I am not against applying as-is, if the relevant
maintainer chooses to.

Thanks
/alessandro

  parent reply	other threads:[~2010-05-12 21:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-11  6:55 [PATCH 1/2] nomadik hwrng: Add clock support srinidhi kasagar
2010-05-12 20:47 ` Matt Mackall
2010-05-12 21:08 ` Alessandro Rubini [this message]
2010-05-12 22:15   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100512210846.GA19831@morgana.i.gnudd.com \
    --to=rubini@unipv.it \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).