* [PATCH] h1940: framebuffer configuration fix
@ 2010-05-12 19:20 Mike Solovyev
2010-05-12 22:43 ` Ben Dooks
2010-05-13 7:25 ` Ben Dooks
0 siblings, 2 replies; 5+ messages in thread
From: Mike Solovyev @ 2010-05-12 19:20 UTC (permalink / raw)
To: linux-arm-kernel
Seems like a typo, wrong setup leads to broken image on ipaq screen.
Signed-off-by: Mike Solovyev <ms@sk.2-ch.org>
Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
---
arch/arm/mach-s3c2410/mach-h1940.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6/arch/arm/mach-s3c2410/mach-h1940.c
===================================================================
--- linux-2.6.orig/arch/arm/mach-s3c2410/mach-h1940.c
+++ linux-2.6/arch/arm/mach-s3c2410/mach-h1940.c
@@ -162,8 +162,8 @@ static struct s3c2410fb_display h1940_lc
.xres = 240,
.yres = 320,
.bpp = 16,
- .left_margin = 20,
- .right_margin = 8,
+ .left_margin = 8,
+ .right_margin = 20,
.hsync_len = 4,
.upper_margin = 8,
.lower_margin = 7,
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] h1940: framebuffer configuration fix
2010-05-12 19:20 [PATCH] h1940: framebuffer configuration fix Mike Solovyev
@ 2010-05-12 22:43 ` Ben Dooks
2010-05-13 7:26 ` Arnaud Patard (Rtp)
2010-05-13 7:25 ` Ben Dooks
1 sibling, 1 reply; 5+ messages in thread
From: Ben Dooks @ 2010-05-12 22:43 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 12, 2010 at 11:20:29PM +0400, Mike Solovyev wrote:
> Seems like a typo, wrong setup leads to broken image on ipaq screen.
arnaud, any comments here?
> Signed-off-by: Mike Solovyev <ms@sk.2-ch.org>
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> ---
> arch/arm/mach-s3c2410/mach-h1940.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-2.6/arch/arm/mach-s3c2410/mach-h1940.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-s3c2410/mach-h1940.c
> +++ linux-2.6/arch/arm/mach-s3c2410/mach-h1940.c
> @@ -162,8 +162,8 @@ static struct s3c2410fb_display h1940_lc
> .xres = 240,
> .yres = 320,
> .bpp = 16,
> - .left_margin = 20,
> - .right_margin = 8,
> + .left_margin = 8,
> + .right_margin = 20,
> .hsync_len = 4,
> .upper_margin = 8,
> .lower_margin = 7,
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] h1940: framebuffer configuration fix
2010-05-12 19:20 [PATCH] h1940: framebuffer configuration fix Mike Solovyev
2010-05-12 22:43 ` Ben Dooks
@ 2010-05-13 7:25 ` Ben Dooks
2010-05-13 7:44 ` Mike Solovyev
1 sibling, 1 reply; 5+ messages in thread
From: Ben Dooks @ 2010-05-13 7:25 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 12, 2010 at 11:20:29PM +0400, Mike Solovyev wrote:
> Seems like a typo, wrong setup leads to broken image on ipaq screen.
>
> Signed-off-by: Mike Solovyev <ms@sk.2-ch.org>
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
surely this should be an acked-by or similar?
> ---
> arch/arm/mach-s3c2410/mach-h1940.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-2.6/arch/arm/mach-s3c2410/mach-h1940.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-s3c2410/mach-h1940.c
> +++ linux-2.6/arch/arm/mach-s3c2410/mach-h1940.c
> @@ -162,8 +162,8 @@ static struct s3c2410fb_display h1940_lc
> .xres = 240,
> .yres = 320,
> .bpp = 16,
> - .left_margin = 20,
> - .right_margin = 8,
> + .left_margin = 8,
> + .right_margin = 20,
> .hsync_len = 4,
> .upper_margin = 8,
> .lower_margin = 7,
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] h1940: framebuffer configuration fix
2010-05-12 22:43 ` Ben Dooks
@ 2010-05-13 7:26 ` Arnaud Patard (Rtp)
0 siblings, 0 replies; 5+ messages in thread
From: Arnaud Patard (Rtp) @ 2010-05-13 7:26 UTC (permalink / raw)
To: linux-arm-kernel
Ben Dooks <ben-linux@fluff.org> writes:
> On Wed, May 12, 2010 at 11:20:29PM +0400, Mike Solovyev wrote:
>> Seems like a typo, wrong setup leads to broken image on ipaq screen.
>
> arnaud, any comments here?
I don't know where the typo came from (and I don't want to know) but
this patch is really needed. I've been using Mike's patch for quite some
time and I'll be happy to see it merged.
Thanks,
Arnaud
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] h1940: framebuffer configuration fix
2010-05-13 7:25 ` Ben Dooks
@ 2010-05-13 7:44 ` Mike Solovyev
0 siblings, 0 replies; 5+ messages in thread
From: Mike Solovyev @ 2010-05-13 7:44 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 13 May 2010 08:25:33 +0100
Ben Dooks <ben-linux@fluff.org> wrote:
> On Wed, May 12, 2010 at 11:20:29PM +0400, Mike Solovyev wrote:
> > Seems like a typo, wrong setup leads to broken image on ipaq screen.
> >
> > Signed-off-by: Mike Solovyev <ms@sk.2-ch.org>
> > Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
>
> surely this should be an acked-by or similar?
I think the right way is:
Signed-off-by: Mike Solovyev <ms@sk.2-ch.org>
Acked-by: Arnaud Patard <arnaud.patard@rtp-net.org>
will resend shortly
--
ms -- http://sk.2-ch.org/gpg.pub
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100513/115928bc/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-05-13 7:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-12 19:20 [PATCH] h1940: framebuffer configuration fix Mike Solovyev
2010-05-12 22:43 ` Ben Dooks
2010-05-13 7:26 ` Arnaud Patard (Rtp)
2010-05-13 7:25 ` Ben Dooks
2010-05-13 7:44 ` Mike Solovyev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).