From mboxrd@z Thu Jan  1 00:00:00 1970
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
Date: Thu, 13 May 2010 10:06:08 +0100
Subject: [PATCH 11/11] ARM: S5P6440: Remove redundant defines
In-Reply-To: <AANLkTilIvm2AlZeh_1cdcgZFFL5YuJUnYiytXA2tZktB@mail.gmail.com>
References: <1273710481-14856-1-git-send-email-kgene.kim@samsung.com>
	<AANLkTimTm_Vxvb2xvJnVxTxUaYguFgGeaWGypzA1yjwM@mail.gmail.com>
	<20100513020236.GS6684@trinity.fluff.org>
	<AANLkTilIvm2AlZeh_1cdcgZFFL5YuJUnYiytXA2tZktB@mail.gmail.com>
Message-ID: <20100513090608.GA5382@n2100.arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Thu, May 13, 2010 at 01:54:12PM +0900, Kyungmin Park wrote:
> On Thu, May 13, 2010 at 11:02 AM, Ben Dooks <ben-linux@fluff.org> wrote:
> > 1) It takes two lines of code, where one is sufficient.
> >
> > 2) You only have to look in the relevant .c file to find out the
> > ? value instead of tracking down a header. This makes it easier
> > ? to verify the value against the manual and easier to compare
> > ? against simialr code.
> 
> Then define it at c code and use the macro. I also don't like the
> hard-coded values.

I'm almost with Ben on this; but we can do better to satisfy both camps.

	.ctrlbit	= 1 << 2, /* CLKCON_MEM0_HCLK_NFCON */

It's now documented what the magic constant is.