From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch 5/6] orion/kirkwood: Add i2s support
Date: Sun, 16 May 2010 18:31:09 +0100 [thread overview]
Message-ID: <20100516173105.GC9830@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20100515153130.937921459@mandriva.com>
On Sat, May 15, 2010 at 05:30:03PM +0200, apatard at mandriva.com wrote:
> This patch enables support for the i2s controller available on orion/kirkwood platforms
>
> Signed-off-by: Arnaud Patard <apatard@mandriva.com>
All looks sensible enough, CCing in Liam. One thing...
> + if (status & ~(ORION_INT_CAUSE_PLAY_BYTES | \
> + ORION_INT_CAUSE_REC_BYTES)) {
> + printk(KERN_WARNING "%s: unexpected interrupt %lx\n",
> + __func__, status);
> + return IRQ_HANDLED;
> + }
Did the driver really handle the interrupt here? It's not even written
an ack back so IRQ_NONE might be a better response (the problem with
using IRQ_NONE before was that the driver may have handled some transfer
interrupts before it got the empty status).
next prev parent reply other threads:[~2010-05-16 17:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-15 15:29 [patch 0/6] kirkwood openrd client audio support - v2 apatard at mandriva.com
2010-05-15 15:29 ` [patch 1/6] orion/kirkwood: add audio functions apatard at mandriva.com
2010-05-16 17:35 ` Mark Brown
2010-05-15 15:30 ` [patch 2/6] openrd-client: initialise audio apatard at mandriva.com
2010-05-16 17:36 ` Mark Brown
2010-05-15 15:30 ` [patch 3/6] ASoC: Add SOC_DOUBLE_R_SX_TLV control apatard at mandriva.com
2010-05-16 17:09 ` Mark Brown
2010-05-15 15:30 ` [patch 4/6] cs42l51: add asoc driver apatard at mandriva.com
2010-05-16 17:27 ` Mark Brown
2010-05-15 15:30 ` [patch 5/6] orion/kirkwood: Add i2s support apatard at mandriva.com
2010-05-16 17:31 ` Mark Brown [this message]
2010-05-17 5:23 ` [alsa-devel] " saeed bishara
2010-05-15 15:30 ` [patch 6/6] kirkwood: Add audio support to openrd client platforms apatard at mandriva.com
2010-05-15 16:52 ` [patch 6/6] kirkwood: Add audio support to openrd?client platforms Alexander Clouter
2010-05-16 17:32 ` [patch 6/6] kirkwood: Add audio support to openrd client platforms Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100516173105.GC9830@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).