[PATCH] serial: SAMSUNG: Fix dev_name and driver_name

[PATCH] serial: SAMSUNG: Fix dev_name and driver_name

[Joonyoung Shim]

Thd dev_name and driver_name should be switched each other.

Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
 drivers/serial/samsung.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c
index a9d6c56..6f3cf70 100644
--- a/drivers/serial/samsung.c
+++ b/drivers/serial/samsung.c
@@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = {
 
 static struct uart_driver s3c24xx_uart_drv = {
 	.owner		= THIS_MODULE,
-	.dev_name	= "s3c2410_serial",
+	.dev_name	= S3C24XX_SERIAL_NAME,
 	.nr		= CONFIG_SERIAL_SAMSUNG_UARTS,
 	.cons		= S3C24XX_SERIAL_CONSOLE,
-	.driver_name	= S3C24XX_SERIAL_NAME,
+	.driver_name	= "s3c2410_serial",
 	.major		= S3C24XX_SERIAL_MAJOR,
 	.minor		= S3C24XX_SERIAL_MINOR,
 };
-- 
1.7.0.4

[PATCH] serial: SAMSUNG: Fix dev_name and driver_name

[Ben Dooks]

On Mon, May 17, 2010 at 09:46:50PM +0900, Joonyoung Shim wrote:
> Thd dev_name and driver_name should be switched each other.

Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet.
 
Please provide some information about what problem that this is fixing
and the impact on any existing systems.

> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
>  drivers/serial/samsung.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c
> index a9d6c56..6f3cf70 100644
> --- a/drivers/serial/samsung.c
> +++ b/drivers/serial/samsung.c
> @@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = {
>  
>  static struct uart_driver s3c24xx_uart_drv = {
>  	.owner		= THIS_MODULE,
> -	.dev_name	= "s3c2410_serial",
> +	.dev_name	= S3C24XX_SERIAL_NAME,
>  	.nr		= CONFIG_SERIAL_SAMSUNG_UARTS,
>  	.cons		= S3C24XX_SERIAL_CONSOLE,
> -	.driver_name	= S3C24XX_SERIAL_NAME,
> +	.driver_name	= "s3c2410_serial",
>  	.major		= S3C24XX_SERIAL_MAJOR,
>  	.minor		= S3C24XX_SERIAL_MINOR,
>  };
> -- 
> 1.7.0.4

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

[PATCH] serial: SAMSUNG: Fix dev_name and driver_name

[Joonyoung Shim]

On 5/18/2010 11:48 AM, Ben Dooks wrote:
> On Mon, May 17, 2010 at 09:46:50PM +0900, Joonyoung Shim wrote:
>> Thd dev_name and driver_name should be switched each other.
> 
> Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet.
>  
> Please provide some information about what problem that this is fixing
> and the impact on any existing systems.
> 

The serial device nodes are created to s3c2410_serial* on android 
platform instead of ttySAC*.

[PATCH] serial: SAMSUNG: Fix dev_name and driver_name

[Ben Dooks]

On Tue, May 18, 2010 at 12:52:13PM +0900, Joonyoung Shim wrote:
> On 5/18/2010 11:48 AM, Ben Dooks wrote:
> > On Mon, May 17, 2010 at 09:46:50PM +0900, Joonyoung Shim wrote:
> >> Thd dev_name and driver_name should be switched each other.
> > 
> > Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet.
> >  
> > Please provide some information about what problem that this is fixing
> > and the impact on any existing systems.
> > 
> 
> The serial device nodes are created to s3c2410_serial* on android 
> platform instead of ttySAC*.

This has been how they've been for ages, surely the android device node
creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx,
like many other operating sysyerms that can already do this.

Changing this just because android (something as-yet unmerged into mainline)
does not like it. I'm not even happy with an #ifdef around this.

If you really feel this is a problem that you absolutely must fix in kernel
then please provide a kernel commandline option to change the serial driver
name and use that on any platform that needs it. Another way would be to
update the serial platform data to have a field for which name to choose.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

[PATCH] serial: SAMSUNG: Fix dev_name and driver_name

[Joonyoung Shim]

On 5/18/2010 2:36 PM, Ben Dooks wrote:
> On Tue, May 18, 2010 at 12:52:13PM +0900, Joonyoung Shim wrote:
>> On 5/18/2010 11:48 AM, Ben Dooks wrote:
>>> On Mon, May 17, 2010 at 09:46:50PM +0900, Joonyoung Shim wrote:
>>>> Thd dev_name and driver_name should be switched each other.
>>> Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet.
>>>  
>>> Please provide some information about what problem that this is fixing
>>> and the impact on any existing systems.
>>>
>> The serial device nodes are created to s3c2410_serial* on android 
>> platform instead of ttySAC*.
> 
> This has been how they've been for ages, surely the android device node
> creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx,
> like many other operating sysyerms that can already do this.
> 
> Changing this just because android (something as-yet unmerged into mainline)
> does not like it. I'm not even happy with an #ifdef around this.
> 

I don't want this too. I wonder if "s3c2410_serial" dev_name is correct?
Most serial drivers have tty prefix to dev_name, so i think ttySACx is more proper.
Please see other serial drivers.