Samsung SoCs framebuffer re-work

Samsung SoCs framebuffer re-work

[Kyungmin Park]

Hi Ben,

Currently there's only one fb drivers for samsung SocS. but it's based
on s3c24xx and a part of s3c64xx.
As you can see the s5pc110 (aka s5pv210) spec, It has more features
and interconnection between FIMC and FIMD.
So current fb driver can't handle these features well. So LSI make a
own fb drivers and use it. You can see the code at their git repo.

Now we are re-implement or change it for s5pc110 and for future usages.
How do you think?

Thank you,
Kyungmin Park

Samsung SoCs framebuffer re-work

[Kukjin Kim]

Kyungmin Park wrote:
> 
> Hi Ben,
> 
> Currently there's only one fb drivers for samsung SocS. but it's based
> on s3c24xx and a part of s3c64xx.
> As you can see the s5pc110 (aka s5pv210) spec, It has more features
> and interconnection between FIMC and FIMD.
> So current fb driver can't handle these features well. So LSI make a
> own fb drivers and use it. You can see the code at their git repo.
> 
> Now we are re-implement or change it for s5pc110 and for future usages.
> How do you think?

Hi,

As you commented, System LSI has own S5PV210/S5PC110 FB driver which is
different from s3c24xx and s3c64xx.

Samsung S.LSI FB driver for S5PV210/S5PC110 has:
- IRQ support for underrun
- VSYNC interrupt
- Configuration variables for virtual screen support
- Change default window from zero
- Double buffering support
- Private IOCTL support
  => control data sources
  => move window positions
  => alpha blending support
- Direct ioctl for FIMD and 3D
- sysfs files for window control

So S.LSI is modifying it to be relatively easy to merge.
And will be submitted soon.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

Samsung SoCs framebuffer re-work

[Ben Dooks]

On Tue, May 18, 2010 at 08:59:29AM +0900, Kyungmin Park wrote:
> Hi Ben,
> 
> Currently there's only one fb drivers for samsung SocS. but it's based
> on s3c24xx and a part of s3c64xx.

Your statement is incorrect, we have the s3c2410-fb driver which deals
with the 2410/2440/2412 style hardware and s3c-fb which is for the newer
devices.

> As you can see the s5pc110 (aka s5pv210) spec, It has more features
> and interconnection between FIMC and FIMD.
> So current fb driver can't handle these features well. So LSI make a
> own fb drivers and use it. You can see the code at their git repo.
> 
> Now we are re-implement or change it for s5pc110 and for future usages.
> How do you think?

I've already got updates for s3c-fb to work on 2416,2443 and the c110/v210
systems. I am talking with the relevant people at System.LSI to get our
drivers closers together, possibly we can get this done for the current
merge window.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

Samsung SoCs framebuffer re-work

[Kyungmin Park]

On Tue, May 18, 2010 at 11:50 AM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Tue, May 18, 2010 at 08:59:29AM +0900, Kyungmin Park wrote:
>> Hi Ben,
>>
>> Currently there's only one fb drivers for samsung SocS. but it's based
>> on s3c24xx and a part of s3c64xx.
>
> Your statement is incorrect, we have the s3c2410-fb driver which deals
> with the 2410/2440/2412 style hardware and s3c-fb which is for the newer
> devices.

Yes it's working on s5pc110. I mean it's not fit the platform requirement.

>
>> As you can see the s5pc110 (aka s5pv210) spec, It has more features
>> and interconnection between FIMC and FIMD.
>> So current fb driver can't handle these features well. So LSI make a
>> own fb drivers and use it. You can see the code at their git repo.
>>
>> Now we are re-implement or change it for s5pc110 and for future usages.
>> How do you think?
>
> I've already got updates for s3c-fb to work on 2416,2443 and the c110/v210
> systems. I am talking with the relevant people at System.LSI to get our
> drivers closers together, possibly we can get this done for the current
> merge window.

You mean you want to use the current fb drivers for s5pc110 also?
Then how to do implement features mentioned by Kukjin?

Thank you,
Kyungmin Park

Samsung SoCs framebuffer re-work

[Ben Dooks]

On Tue, May 18, 2010 at 12:09:25PM +0900, Kyungmin Park wrote:
> On Tue, May 18, 2010 at 11:50 AM, Ben Dooks <ben-linux@fluff.org> wrote:
> > On Tue, May 18, 2010 at 08:59:29AM +0900, Kyungmin Park wrote:
> >> Hi Ben,
> >>
> >> Currently there's only one fb drivers for samsung SocS. but it's based
> >> on s3c24xx and a part of s3c64xx.
> >
> > Your statement is incorrect, we have the s3c2410-fb driver which deals
> > with the 2410/2440/2412 style hardware and s3c-fb which is for the newer
> > devices.
> 
> Yes it's working on s5pc110. I mean it's not fit the platform requirement.

?
 
> >
> >> As you can see the s5pc110 (aka s5pv210) spec, It has more features
> >> and interconnection between FIMC and FIMD.
> >> So current fb driver can't handle these features well. So LSI make a
> >> own fb drivers and use it. You can see the code at their git repo.
> >>
> >> Now we are re-implement or change it for s5pc110 and for future usages.
> >> How do you think?
> >
> > I've already got updates for s3c-fb to work on 2416,2443 and the c110/v210
> > systems. I am talking with the relevant people at System.LSI to get our
> > drivers closers together, possibly we can get this done for the current
> > merge window.
> 
> You mean you want to use the current fb drivers for s5pc110 also?
> Then how to do implement features mentioned by Kukjin?

Well, apart from the fact that quite a lot of them are actually features
that are in all versions of this block, we intend to create some patches
and send them to the relevant lists...

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

Samsung SoCs framebuffer re-work

[Pawel Osciak]

> Ben Dooks wrote:
>On Tue, May 18, 2010 at 12:09:25PM +0900, Kyungmin Park wrote:
>> On Tue, May 18, 2010 at 11:50 AM, Ben Dooks <ben-linux@fluff.org> wrote:
>> > On Tue, May 18, 2010 at 08:59:29AM +0900, Kyungmin Park wrote:
>> >
>> >> As you can see the s5pc110 (aka s5pv210) spec, It has more features
>> >> and interconnection between FIMC and FIMD.
>> >> So current fb driver can't handle these features well. So LSI make a
>> >> own fb drivers and use it. You can see the code at their git repo.
>> >>
>> >> Now we are re-implement or change it for s5pc110 and for future usages.
>> >> How do you think?
>> >
>> > I've already got updates for s3c-fb to work on 2416,2443 and the
>c110/v210
>> > systems. I am talking with the relevant people at System.LSI to get our
>> > drivers closers together, possibly we can get this done for the current
>> > merge window.
>>
>> You mean you want to use the current fb drivers for s5pc110 also?
>> Then how to do implement features mentioned by Kukjin?
>
>Well, apart from the fact that quite a lot of them are actually features
>that are in all versions of this block, we intend to create some patches
>and send them to the relevant lists...

I posted patches for s3c-fb back in September (Sep. 3rd and 11th), which
added some of the abovementioned features, including VSYNC, double-buffering
support, color-keying, alpha blending and more. Are there any plans for
those?

Best regards
--
Pawel Osciak
Linux Platform Group
Samsung Poland R&D Center

Samsung SoCs framebuffer re-work

[Ben Dooks]

On Tue, May 18, 2010 at 08:54:44AM +0200, Pawel Osciak wrote:
> 
> > Ben Dooks wrote:
> >On Tue, May 18, 2010 at 12:09:25PM +0900, Kyungmin Park wrote:
> >> On Tue, May 18, 2010 at 11:50 AM, Ben Dooks <ben-linux@fluff.org> wrote:
> >> > On Tue, May 18, 2010 at 08:59:29AM +0900, Kyungmin Park wrote:
> >> >
> >> >> As you can see the s5pc110 (aka s5pv210) spec, It has more features
> >> >> and interconnection between FIMC and FIMD.
> >> >> So current fb driver can't handle these features well. So LSI make a
> >> >> own fb drivers and use it. You can see the code at their git repo.
> >> >>
> >> >> Now we are re-implement or change it for s5pc110 and for future usages.
> >> >> How do you think?
> >> >
> >> > I've already got updates for s3c-fb to work on 2416,2443 and the
> >c110/v210
> >> > systems. I am talking with the relevant people at System.LSI to get our
> >> > drivers closers together, possibly we can get this done for the current
> >> > merge window.
> >>
> >> You mean you want to use the current fb drivers for s5pc110 also?
> >> Then how to do implement features mentioned by Kukjin?
> >
> >Well, apart from the fact that quite a lot of them are actually features
> >that are in all versions of this block, we intend to create some patches
> >and send them to the relevant lists...
> 
> I posted patches for s3c-fb back in September (Sep. 3rd and 11th), which
> added some of the abovementioned features, including VSYNC, double-buffering
> support, color-keying, alpha blending and more. Are there any plans for
> those?

Either not seen them or missed them completely.

Do you have URLs to have a look at them?

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

Samsung SoCs framebuffer re-work

[Pawel Osciak]

>Ben Dooks <mailto:ben-linux@fluff.org> wrote:
>On Tue, May 18, 2010 at 08:54:44AM +0200, Pawel Osciak wrote:
>>
>> > Ben Dooks wrote:
>> >On Tue, May 18, 2010 at 12:09:25PM +0900, Kyungmin Park wrote:
>> >> On Tue, May 18, 2010 at 11:50 AM, Ben Dooks <ben-linux@fluff.org> wrote:
>> >> > On Tue, May 18, 2010 at 08:59:29AM +0900, Kyungmin Park wrote:
>> >> >
>> >> >> As you can see the s5pc110 (aka s5pv210) spec, It has more features
>> >> >> and interconnection between FIMC and FIMD.
>> >> >> So current fb driver can't handle these features well. So LSI make a
>> >> >> own fb drivers and use it. You can see the code at their git repo.
>> >> >>
>> >> >> Now we are re-implement or change it for s5pc110 and for future
>usages.
>> >> >> How do you think?
>> >> >
>> >> > I've already got updates for s3c-fb to work on 2416,2443 and the
>> >c110/v210
>> >> > systems. I am talking with the relevant people at System.LSI to get
>our
>> >> > drivers closers together, possibly we can get this done for the
>current
>> >> > merge window.
>> >>
>> >> You mean you want to use the current fb drivers for s5pc110 also?
>> >> Then how to do implement features mentioned by Kukjin?
>> >
>> >Well, apart from the fact that quite a lot of them are actually features
>> >that are in all versions of this block, we intend to create some patches
>> >and send them to the relevant lists...
>>
>> I posted patches for s3c-fb back in September (Sep. 3rd and 11th), which
>> added some of the abovementioned features, including VSYNC, double-
>buffering
>> support, color-keying, alpha blending and more. Are there any plans for
>> those?
>
>Either not seen them or missed them completely.
>
>Do you have URLs to have a look at them?

[PATCH v2 0/3] v2: s3c-fb panning and vsync support:
http://lists.infradead.org/pipermail/linux-arm-kernel/2009-September/000370.html

[PATCH 0/7] [ARM] s3c-fb: Various s3c-fb updates:
http://lists.infradead.org/pipermail/linux-arm-kernel/2009-September/000600.html


Best regards
--
Pawel Osciak
Linux Platform Group
Samsung Poland R&D Center