From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/8] ARM: SAMSUNG: Fixed coding style issue
Date: Tue, 18 May 2010 08:30:50 +0100 [thread overview]
Message-ID: <20100518073050.GF26401@trinity.fluff.org> (raw)
In-Reply-To: <1274162347-557-1-git-send-email-kgene.kim@samsung.com>
On Tue, May 18, 2010 at 02:59:07PM +0900, Kukjin Kim wrote:
> From: Taekgyun Ko <taeggyun.ko@samsung.com>
>
> Fixed a coding style issue.
This message is lacking in information.
Normally coding style patches are something that get ignored, but
this time I'm geeling generous and will take it.
> Signed-off-by: Taekgyun Ko <taeggyun.ko@samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> arch/arm/plat-samsung/include/plat/regs-rtc.h | 68 ++++++++++++-------------
> 1 files changed, 33 insertions(+), 35 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/include/plat/regs-rtc.h b/arch/arm/plat-samsung/include/plat/regs-rtc.h
> index d5837cf..5b547ce 100644
> --- a/arch/arm/plat-samsung/include/plat/regs-rtc.h
> +++ b/arch/arm/plat-samsung/include/plat/regs-rtc.h
> @@ -13,49 +13,47 @@
> #ifndef __ASM_ARCH_REGS_RTC_H
> #define __ASM_ARCH_REGS_RTC_H __FILE__
>
> -#define S3C2410_RTCREG(x) (x)
> -
> -#define S3C2410_RTCCON S3C2410_RTCREG(0x40)
> -#define S3C2410_RTCCON_RTCEN (1<<0)
> -#define S3C2410_RTCCON_CLKSEL (1<<1)
> -#define S3C2410_RTCCON_CNTSEL (1<<2)
> -#define S3C2410_RTCCON_CLKRST (1<<3)
> -
> -#define S3C2410_TICNT S3C2410_RTCREG(0x44)
> -#define S3C2410_TICNT_ENABLE (1<<7)
> -
> -#define S3C2410_RTCALM S3C2410_RTCREG(0x50)
> -#define S3C2410_RTCALM_ALMEN (1<<6)
> -#define S3C2410_RTCALM_YEAREN (1<<5)
> -#define S3C2410_RTCALM_MONEN (1<<4)
> -#define S3C2410_RTCALM_DAYEN (1<<3)
> -#define S3C2410_RTCALM_HOUREN (1<<2)
> -#define S3C2410_RTCALM_MINEN (1<<1)
> -#define S3C2410_RTCALM_SECEN (1<<0)
> +#define S3C2410_RTCREG(x) (x)
> +
> +#define S3C2410_RTCCON S3C2410_RTCREG(0x40)
> +#define S3C2410_RTCCON_RTCEN (1 << 0)
> +#define S3C2410_RTCCON_CLKSEL (1 << 1)
> +#define S3C2410_RTCCON_CNTSEL (1 << 2)
> +#define S3C2410_RTCCON_CLKRST (1 << 3)
> +
> +#define S3C2410_TICNT S3C2410_RTCREG(0x44)
> +#define S3C2410_TICNT_ENABLE (1 << 7)
> +
> +#define S3C2410_RTCALM S3C2410_RTCREG(0x50)
> +#define S3C2410_RTCALM_ALMEN (1 << 6)
> +#define S3C2410_RTCALM_YEAREN (1 << 5)
> +#define S3C2410_RTCALM_MONEN (1 << 4)
> +#define S3C2410_RTCALM_DAYEN (1 << 3)
> +#define S3C2410_RTCALM_HOUREN (1 << 2)
> +#define S3C2410_RTCALM_MINEN (1 << 1)
> +#define S3C2410_RTCALM_SECEN (1 << 0)
>
> #define S3C2410_RTCALM_ALL \
> S3C2410_RTCALM_ALMEN | S3C2410_RTCALM_YEAREN | S3C2410_RTCALM_MONEN |\
> S3C2410_RTCALM_DAYEN | S3C2410_RTCALM_HOUREN | S3C2410_RTCALM_MINEN |\
> S3C2410_RTCALM_SECEN
>
> +#define S3C2410_ALMSEC S3C2410_RTCREG(0x54)
> +#define S3C2410_ALMMIN S3C2410_RTCREG(0x58)
> +#define S3C2410_ALMHOUR S3C2410_RTCREG(0x5c)
>
> -#define S3C2410_ALMSEC S3C2410_RTCREG(0x54)
> -#define S3C2410_ALMMIN S3C2410_RTCREG(0x58)
> -#define S3C2410_ALMHOUR S3C2410_RTCREG(0x5c)
> +#define S3C2410_ALMDATE S3C2410_RTCREG(0x60)
> +#define S3C2410_ALMMON S3C2410_RTCREG(0x64)
> +#define S3C2410_ALMYEAR S3C2410_RTCREG(0x68)
>
> -#define S3C2410_ALMDATE S3C2410_RTCREG(0x60)
> -#define S3C2410_ALMMON S3C2410_RTCREG(0x64)
> -#define S3C2410_ALMYEAR S3C2410_RTCREG(0x68)
> -
> -#define S3C2410_RTCRST S3C2410_RTCREG(0x6c)
> -
> -#define S3C2410_RTCSEC S3C2410_RTCREG(0x70)
> -#define S3C2410_RTCMIN S3C2410_RTCREG(0x74)
> -#define S3C2410_RTCHOUR S3C2410_RTCREG(0x78)
> -#define S3C2410_RTCDATE S3C2410_RTCREG(0x7c)
> -#define S3C2410_RTCDAY S3C2410_RTCREG(0x80)
> -#define S3C2410_RTCMON S3C2410_RTCREG(0x84)
> -#define S3C2410_RTCYEAR S3C2410_RTCREG(0x88)
> +#define S3C2410_RTCRST S3C2410_RTCREG(0x6c)
>
> +#define S3C2410_RTCSEC S3C2410_RTCREG(0x70)
> +#define S3C2410_RTCMIN S3C2410_RTCREG(0x74)
> +#define S3C2410_RTCHOUR S3C2410_RTCREG(0x78)
> +#define S3C2410_RTCDATE S3C2410_RTCREG(0x7c)
> +#define S3C2410_RTCDAY S3C2410_RTCREG(0x80)
> +#define S3C2410_RTCMON S3C2410_RTCREG(0x84)
> +#define S3C2410_RTCYEAR S3C2410_RTCREG(0x88)
>
> #endif /* __ASM_ARCH_REGS_RTC_H */
> --
> 1.6.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
prev parent reply other threads:[~2010-05-18 7:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 5:59 [PATCH 2/8] ARM: SAMSUNG: Fixed coding style issue Kukjin Kim
2010-05-18 7:30 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518073050.GF26401@trinity.fluff.org \
--to=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).