From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 3/3] ep93xx i2s snapper cl15 support
Date: Tue, 18 May 2010 19:44:33 +0100 [thread overview]
Message-ID: <20100518184433.GE22554@sirena.org.uk> (raw)
In-Reply-To: <4BF21DB0.2070908@bluewatersys.com>
On Tue, May 18, 2010 at 04:55:12PM +1200, Ryan Mallon wrote:
> +//#define CODEC_CLOCK 11289600
> +#define CODEC_CLOCK 5644800
Hrm?
> +
> +static int snappercl15_startup(struct snd_pcm_substream *substream)
> +{
> + return 0;
> +}
Remove this and all other empty functions.
> +static int snappercl15_tlv320aic23_init(struct snd_soc_codec *codec)
> +{
> + printk(KERN_INFO "%s - here\n", __FUNCTION__);
Debug code, should probably be removed or at least make pr_debug().
> + snd_soc_dapm_enable_pin(codec, "Headphone Jack");
> + snd_soc_dapm_enable_pin(codec, "Line In");
> + snd_soc_dapm_enable_pin(codec, "Mic Jack");
No need to enable pins, this is the default condition. You could mark
any unused pins on the CODEC as _nc_pin() though.
> + snd_soc_dapm_sync(codec);
The core should take care of this for you (so many machines need it that
it was pulled in).
next prev parent reply other threads:[~2010-05-18 18:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 4:45 [RFC PATCH 0/3] ep93xx i2s audio Ryan Mallon
2010-05-18 4:53 ` [RFC PATCH 1/3] ep93xx i2s driver Ryan Mallon
2010-05-18 12:45 ` Chase Douglas
2010-05-18 18:37 ` Mark Brown
2010-05-18 21:21 ` Ryan Mallon
2010-05-18 17:54 ` H Hartley Sweeten
2010-05-18 21:34 ` Ryan Mallon
2010-05-18 18:33 ` Mark Brown
2010-05-18 4:54 ` [RFC PATCH 2/3] ep93xx i2s core support Ryan Mallon
2010-05-18 12:46 ` Chase Douglas
2010-05-18 21:23 ` Ryan Mallon
2010-05-18 18:26 ` H Hartley Sweeten
2010-05-18 4:55 ` [RFC PATCH 3/3] ep93xx i2s snapper cl15 support Ryan Mallon
2010-05-18 12:46 ` Chase Douglas
2010-05-18 18:37 ` H Hartley Sweeten
2010-05-18 18:44 ` Mark Brown [this message]
2010-05-18 12:44 ` [RFC PATCH 0/3] ep93xx i2s audio Chase Douglas
2010-05-18 18:22 ` Mark Brown
2010-05-18 21:06 ` Ryan Mallon
2010-05-18 18:46 ` Mark Brown
2010-05-18 21:04 ` Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518184433.GE22554@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).