From: daniel@caiaq.de (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] pxa/colibri270: Refactor board definition file
Date: Wed, 19 May 2010 08:36:21 +0200 [thread overview]
Message-ID: <20100519063621.GL30801@buzzloop.caiaq.de> (raw)
In-Reply-To: <20100514103757.GN30807@buzzloop.caiaq.de>
Any update on this?
On Fri, May 14, 2010 at 12:37:57PM +0200, Daniel Mack wrote:
> On Tue, May 11, 2010 at 04:26:55AM +0200, Marek Vasut wrote:
>
> [...]
>
> > -/*
> > - * NOR flash
> > - */
> > +/******************************************************************************
> > + * NOR Flash
> > + ******************************************************************************/
> > +#if defined(CONFIG_MTD_PHYSMAP) || defined(CONFIG_MTD_PHYSMAP_MODULE)
> > static struct mtd_partition colibri_partitions[] = {
> > {
> > .name = "Bootloader",
> > .offset = 0x00000000,
> > .size = 0x00040000,
> > - .mask_flags = MTD_WRITEABLE /* force read-only */
> > + .mask_flags = MTD_WRITEABLE /* force read-only */
> > }, {
> > .name = "Kernel",
> > .offset = 0x00040000,
> > @@ -90,42 +93,50 @@ static struct platform_device colibri_pxa270_flash_device = {
> > .num_resources = 1,
> > };
> >
> > -/*
> > - * DM9000 Ethernet
> > - */
> > -#if defined(CONFIG_DM9000)
> > -static struct resource dm9000_resources[] = {
> > +static void __init colibri_pxa270_nor_init(void)
> > +{
> > + platform_device_register(&colibri_pxa270_flash);
>
> Erm ...
>
> arch/arm/mach-pxa/colibri-pxa270.c: In function 'colibri_pxa270_nor_init':
> arch/arm/mach-pxa/colibri-pxa270.c:131: error: 'colibri_pxa270_flash' undeclared (first use in this function)
> arch/arm/mach-pxa/colibri-pxa270.c:131: error: (Each undeclared identifier is reported only once
> arch/arm/mach-pxa/colibri-pxa270.c:131: error: for each function it appears in.)
> make[1]: *** [arch/arm/mach-pxa/colibri-pxa270.o] Error 1
> make: *** [arch/arm/mach-pxa] Error 2
> make: *** Waiting for unfinished jobs....
>
> Eric, is that patch already queued?
>
> I can send a trivial fix up - or should Marek send a new version of this
> patch?
>
> Daniel
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2010-05-19 6:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 2:26 [PATCH 1/4] pxa/colibri270: Refactor board definition file Marek Vasut
2010-05-11 2:26 ` [PATCH 2/4] pxa/colibri270: Add MMC support Marek Vasut
2010-05-11 8:52 ` Daniel Mack
2010-05-11 10:46 ` Eric Miao
2010-05-11 10:48 ` Daniel Mack
2010-05-11 2:26 ` [PATCH 3/4] pxa/colibri270: Add FFUART MFP Marek Vasut
2010-05-11 2:26 ` [PATCH 4/4] pxa/colibri270: Add UHC support Marek Vasut
2010-05-11 8:48 ` [PATCH 1/4] pxa/colibri270: Refactor board definition file Daniel Mack
2010-05-14 10:37 ` Daniel Mack
2010-05-19 6:36 ` Daniel Mack [this message]
2010-05-21 2:36 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100519063621.GL30801@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).