* [PATCH 01/11] [ARM] pxa: Storage class should be before const qualifier
@ 2010-05-20 8:31 Tobias Klauser
2010-05-20 10:26 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Tobias Klauser @ 2010-05-20 8:31 UTC (permalink / raw)
To: linux-arm-kernel
The C99 specification states in section 6.11.5:
The placement of a storage-class specifier other than at the beginning
of the declaration specifiers in a declaration is an obsolescent
feature.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
arch/arm/mach-pxa/palmtc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-pxa/palmtc.c b/arch/arm/mach-pxa/palmtc.c
index 033b567..ce1104d 100644
--- a/arch/arm/mach-pxa/palmtc.c
+++ b/arch/arm/mach-pxa/palmtc.c
@@ -263,11 +263,11 @@ const struct matrix_keymap_data palmtc_keymap_data = {
.keymap_size = ARRAY_SIZE(palmtc_matrix_keys),
};
-const static unsigned int palmtc_keypad_row_gpios[] = {
+static const unsigned int palmtc_keypad_row_gpios[] = {
0, 9, 10, 11
};
-const static unsigned int palmtc_keypad_col_gpios[] = {
+static const unsigned int palmtc_keypad_col_gpios[] = {
18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 79, 80
};
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 01/11] [ARM] pxa: Storage class should be before const qualifier
2010-05-20 8:31 [PATCH 01/11] [ARM] pxa: Storage class should be before const qualifier Tobias Klauser
@ 2010-05-20 10:26 ` Marek Vasut
2010-05-20 15:05 ` Eric Miao
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2010-05-20 10:26 UTC (permalink / raw)
To: linux-arm-kernel
Dne ?t 20. kv?tna 2010 10:31:46 Tobias Klauser napsal(a):
> The C99 specification states in section 6.11.5:
>
> The placement of a storage-class specifier other than at the beginning
> of the declaration specifiers in a declaration is an obsolescent
> feature.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> arch/arm/mach-pxa/palmtc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/palmtc.c b/arch/arm/mach-pxa/palmtc.c
> index 033b567..ce1104d 100644
> --- a/arch/arm/mach-pxa/palmtc.c
> +++ b/arch/arm/mach-pxa/palmtc.c
> @@ -263,11 +263,11 @@ const struct matrix_keymap_data palmtc_keymap_data =
> { .keymap_size = ARRAY_SIZE(palmtc_matrix_keys),
> };
>
> -const static unsigned int palmtc_keypad_row_gpios[] = {
> +static const unsigned int palmtc_keypad_row_gpios[] = {
> 0, 9, 10, 11
> };
>
> -const static unsigned int palmtc_keypad_col_gpios[] = {
> +static const unsigned int palmtc_keypad_col_gpios[] = {
> 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 79, 80
> };
Ok, if that's the case, you have my ack:
Acked-by: Marek Vasut <marek.vasut@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 01/11] [ARM] pxa: Storage class should be before const qualifier
2010-05-20 10:26 ` Marek Vasut
@ 2010-05-20 15:05 ` Eric Miao
0 siblings, 0 replies; 3+ messages in thread
From: Eric Miao @ 2010-05-20 15:05 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, May 20, 2010 at 6:26 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> Dne ?t 20. kv?tna 2010 10:31:46 Tobias Klauser napsal(a):
>> The C99 specification states in section 6.11.5:
>>
>> The placement of a storage-class specifier other than at the beginning
>> of the declaration specifiers in a declaration is an obsolescent
>> feature.
>>
>> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
>> ---
>> ?arch/arm/mach-pxa/palmtc.c | ? ?4 ++--
>> ?1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-pxa/palmtc.c b/arch/arm/mach-pxa/palmtc.c
>> index 033b567..ce1104d 100644
>> --- a/arch/arm/mach-pxa/palmtc.c
>> +++ b/arch/arm/mach-pxa/palmtc.c
>> @@ -263,11 +263,11 @@ const struct matrix_keymap_data palmtc_keymap_data =
>> { .keymap_size ? ? ? ? ? ? ? ?= ARRAY_SIZE(palmtc_matrix_keys),
>> ?};
>>
>> -const static unsigned int palmtc_keypad_row_gpios[] = {
>> +static const unsigned int palmtc_keypad_row_gpios[] = {
>> ? ? ? 0, 9, 10, 11
>> ?};
>>
>> -const static unsigned int palmtc_keypad_col_gpios[] = {
>> +static const unsigned int palmtc_keypad_col_gpios[] = {
>> ? ? ? 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 79, 80
>> ?};
>
> Ok, if that's the case, you have my ack:
>
> Acked-by: Marek Vasut <marek.vasut@gmail.com>
>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-20 15:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-20 8:31 [PATCH 01/11] [ARM] pxa: Storage class should be before const qualifier Tobias Klauser
2010-05-20 10:26 ` Marek Vasut
2010-05-20 15:05 ` Eric Miao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).