From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] s3c24xx fix: freeze during suspend/resume on s3c24xx if some GPIO banks not present
Date: Mon, 24 May 2010 04:32:23 +0100 [thread overview]
Message-ID: <20100524033223.GC7248@trinity.fluff.org> (raw)
In-Reply-To: <4BF8F30B.9040704@ru.mvista.com>
On Sun, May 23, 2010 at 01:19:07PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> Pinkava J. wrote:
>
>> When saving GPIOs during suspend/resume we need skip missing GPIO banks, not
>> trying get corresponding chip again and again in infinite loop.
>
> I didn't see any infinite loops there -- *continue* itself leads to
> incrementing 'gpio_nr', no?
no, I made a bit of a mess playing with this patch, so this should fix
it (now applied).
Really I could do with a list of all registered s3c_gpio_chips to allow
for a more efficient implementation, but it is a bit late for that for
this merge window.
>> Signed-off-by: Jiri Pinkava <jiri.pinkava@vscht.cz>
>> ---
>> arch/arm/plat-samsung/pm-gpio.c | 8 ++++++--
>> 1 files changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/plat-samsung/pm-gpio.c b/arch/arm/plat-samsung/pm-gpio.c
>> index d50ab9d..7df03f8 100644
>> --- a/arch/arm/plat-samsung/pm-gpio.c
>> +++ b/arch/arm/plat-samsung/pm-gpio.c
>> @@ -331,8 +331,10 @@ void s3c_pm_save_gpios(void)
>>
>> for (gpio_nr = 0; gpio_nr < S3C_GPIO_END;) {
>> ourchip = s3c_gpiolib_getchip(gpio_nr);
>> - if (!ourchip)
>> + if (!ourchip) {
>> + gpio_nr++;
>> continue;
>> + }
>>
>> s3c_pm_save_gpio(ourchip);
>>
>> @@ -369,8 +371,10 @@ void s3c_pm_restore_gpios(void)
>>
>> for (gpio_nr = 0; gpio_nr < S3C_GPIO_END;) {
>> ourchip = s3c_gpiolib_getchip(gpio_nr);
>> - if (!ourchip)
>> + if (!ourchip) {
>> + gpio_nr++;
>> continue;
>> + }
>>
>> s3c_pm_resume_gpio(ourchip);
>
> WBR, Sergei
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2010-05-24 3:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-23 4:42 [PATCH] s3c24xx fix: freeze during suspend/resume on s3c24xx if some GPIO banks not present Pinkava J.
2010-05-23 9:19 ` Sergei Shtylyov
2010-05-23 12:34 ` Pinkava J.
2010-05-24 7:57 ` Sergei Shtylyov
2010-05-24 3:32 ` Ben Dooks [this message]
2010-05-23 13:18 ` Pinkava J.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100524033223.GC7248@trinity.fluff.org \
--to=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).