From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 10/14] omap: mailbox: reorganize registering
Date: Mon, 24 May 2010 19:32:49 +0100 [thread overview]
Message-ID: <20100524183249.GF21117@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20100524.182407.67910029.Hiroshi.DOYU@nokia.com>
On Mon, May 24, 2010 at 06:24:07PM +0300, Hiroshi DOYU wrote:
> From: ext Felipe Contreras <felipe.contreras@gmail.com>
> Subject: [PATCH v3 10/14] omap: mailbox: reorganize registering
> Date: Sat, 22 May 2010 19:14:21 +0200
>
> > platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - if (unlikely(!res)) {
> > - dev_err(&pdev->dev, "invalid mem resource\n");
> > - return -ENODEV;
> > - }
> > + res = pdev->resource;
>
> why not?
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
I agree - always use the accessors provided rather than going beneath
the covers and fiddling directly with stuff inside objects.
next prev parent reply other threads:[~2010-05-24 18:32 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 17:14 [PATCH v3 00/14] omap: mailbox: bunch of cleanups Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 01/14] omap: mailbox: trivial whitespace cleanups Felipe Contreras
2010-05-24 10:56 ` Hiroshi DOYU
2010-05-22 17:14 ` [PATCH v3 02/14] omap: mailbox: trivial cleanups Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 03/14] omap: mailbox: reorganize structures Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 04/14] omap: mailbox: 2420 should be detected at run-time Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 05/14] omap: mailbox: use correct config for omap1 Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 06/14] omap: mailbox: update omap1 probing Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 07/14] omap: mailbox: don't export unecessary symbols Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 08/14] omap: mailbox: remove unecessary fields Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 09/14] omap: mailbox: add IRQ names Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 10/14] omap: mailbox: reorganize registering Felipe Contreras
2010-05-24 15:24 ` Hiroshi DOYU
2010-05-24 18:32 ` Russell King - ARM Linux [this message]
2010-05-24 19:17 ` Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 11/14] omap: mailbox: only compile for configured archs Felipe Contreras
2010-05-24 14:42 ` Hiroshi DOYU
2010-05-24 19:29 ` Felipe Contreras
2010-05-24 21:00 ` Russell King - ARM Linux
2010-05-22 17:14 ` [PATCH v3 12/14] omap: mailbox: standarize on 'omap-mailbox' Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 13/14] omap: mailbox: simplify omap_mbox_register() Felipe Contreras
2010-05-24 14:42 ` Hiroshi DOYU
2010-06-11 15:17 ` Felipe Contreras
2010-06-11 15:19 ` Felipe Contreras
2010-05-24 15:14 ` Hiroshi DOYU
2010-05-22 17:14 ` [PATCH v3 14/14] omap: mailbox: reorganize headers Felipe Contreras
2010-05-24 17:16 ` Felipe Balbi
2010-05-24 19:14 ` Felipe Contreras
2010-05-25 5:49 ` Felipe Balbi
2010-05-25 18:04 ` Felipe Contreras
2010-06-03 6:40 ` [PATCH v3 00/14] omap: mailbox: bunch of cleanups Hiroshi DOYU
2010-06-03 10:23 ` Felipe Contreras
2010-06-03 10:59 ` Hiroshi DOYU
2010-06-03 11:47 ` Russell King - ARM Linux
2010-06-03 11:56 ` Felipe Balbi
2010-06-03 12:05 ` Baruch Siach
2010-06-03 14:59 ` Felipe Contreras
2010-06-03 16:15 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100524183249.GF21117@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).